Source/bindings/scripts/idl_reader.py - Issue 473893002: Add 'idl_name' to IdlDefinition, IdlOperation, IdlAttribute etc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/idl_reader.py

Issue 473893002: Add 'idl_name' to IdlDefinition, IdlOperation, IdlAttribute etc (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/idl_reader.py

diff --git a/Source/bindings/scripts/idl_reader.py b/Source/bindings/scripts/idl_reader.py

index 8fca1c43326e1b226ba61573aeba900eff3bb3a4..8a8cd4f679db0c3f7ab5fd2ade86da9f98b70bd3 100644

--- a/Source/bindings/scripts/idl_reader.py

+++ b/Source/bindings/scripts/idl_reader.py

@@ -69,7 +69,8 @@ class IdlReader(object):

ast = blink_idl_parser.parse_file(self.parser, idl_filename)

if not ast:

raise Exception('Failed to parse %s' % idl_filename)

- definitions = IdlDefinitions(ast)

+ idl_name = os.path.basename(idl_filename)

+ definitions = IdlDefinitions(idl_name, ast)

# Validate file contents with filename convention

# The Blink IDL filenaming convention is that the file

« no previous file with comments | « Source/bindings/scripts/idl_definitions.py ('k') | Source/bindings/scripts/v8_interface.py » ('j') | no next file with comments »