Issue 473883002: Revert 289403 "Update iOS deployment target to 7.0"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 473883002: Revert 289403 "Update iOS deployment target to 7.0" (Closed)

Created:
6 years, 4 months ago by bartfab (slow)

Modified:
6 years, 4 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 289403 "Update iOS deployment target to 7.0" This appears to have broken gfx_unittests on iOS: http://build.chromium.org/p/chromium.mac/builders/iOS%20Simulator%20%28dbg%29/builds/17689 > Update iOS deployment target to 7.0 > > iOS 6 will no longer be supported. > > Replaces deprecated sizeWithFont: with sizeWithAttributes: (adding a > ceilf since according to the internet, the former rounds up, and the > latter does not) to fix compilation. > > BUG=402921 > > Review URL: https://codereview.chromium.org/463333002 TBR=stuartmorgan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289510

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -11 lines)			Patch
M	trunk/src/build/common.gypi	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	trunk/src/ui/gfx/platform_font_ios.mm	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	trunk/src/ui/gfx/text_utils_ios.mm	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

LGTM. I'm perplexed by http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/5212 where the try server had the same failure but called ...

6 years, 4 months ago (2014-08-14 14:12:12 UTC) #3

bartfab (slow)

6 years, 4 months ago (2014-08-14 14:19:39 UTC) #4

Message was sent while issue was closed.

On 2014/08/14 14:12:12, stuartmorgan wrote:
> LGTM.
> 
> I'm perplexed by
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...
> where the try server had the same failure but called the run green :P

Yes, I filed http://crbug.com/403725 for that.

Expand Messages | Collapse Messages