Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 463333002: Update iOS deployment target to 7.0 (Closed)

Created:
6 years, 4 months ago by stuartmorgan
Modified:
5 years, 2 months ago
Reviewers:
Nico, sdefresne
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Update iOS deployment target to 7.0 iOS 6 will no longer be supported. Replaces deprecated sizeWithFont: with sizeWithAttributes: (adding a ceilf since according to the internet, the former rounds up, and the latter does not) to fix compilation. BUG=402921 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289403

Patch Set 1 #

Total comments: 4

Patch Set 2 : Switch to std::ceil #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M build/common.gypi View 2 chunks +5 lines, -1 line 0 comments Download
M ui/gfx/platform_font_ios.mm View 1 2 chunks +4 lines, -1 line 0 comments Download
M ui/gfx/text_utils_ios.mm View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
stuartmorgan
Nico for gfx/ owners (and also because you'll probably be amused to know that the ...
6 years, 4 months ago (2014-08-12 22:48:40 UTC) #1
Nico
lgtm
6 years, 4 months ago (2014-08-12 22:56:50 UTC) #2
stuartmorgan
+Sylvain for a look at the gyp change since it's related to the libc++ work.
6 years, 4 months ago (2014-08-12 22:58:10 UTC) #3
sdefresne
LGTM with nits https://codereview.chromium.org/463333002/diff/1/ui/gfx/platform_font_ios.mm File ui/gfx/platform_font_ios.mm (right): https://codereview.chromium.org/463333002/diff/1/ui/gfx/platform_font_ios.mm#newcode114 ui/gfx/platform_font_ios.mm:114: average_width_ = ceilf([@"x" sizeWithAttributes:attributes].width); nit: why ...
6 years, 4 months ago (2014-08-13 09:30:37 UTC) #4
stuartmorgan
https://codereview.chromium.org/463333002/diff/1/ui/gfx/platform_font_ios.mm File ui/gfx/platform_font_ios.mm (right): https://codereview.chromium.org/463333002/diff/1/ui/gfx/platform_font_ios.mm#newcode114 ui/gfx/platform_font_ios.mm:114: average_width_ = ceilf([@"x" sizeWithAttributes:attributes].width); On 2014/08/13 09:30:37, sdefresne wrote: ...
6 years, 4 months ago (2014-08-13 14:07:36 UTC) #5
stuartmorgan
The CQ bit was checked by stuartmorgan@chromium.org
6 years, 4 months ago (2014-08-13 14:07:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/463333002/20001
6 years, 4 months ago (2014-08-13 14:08:34 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-13 16:45:38 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 17:07:57 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/5315)
6 years, 4 months ago (2014-08-13 17:07:59 UTC) #10
stuartmorgan
The CQ bit was checked by stuartmorgan@chromium.org
6 years, 4 months ago (2014-08-13 21:25:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/463333002/20001
6 years, 4 months ago (2014-08-13 21:27:00 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 22:50:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (20001) as 289403

Powered by Google App Engine
This is Rietveld 408576698