Issue 473813002: Revert 289480 "Still produce quad when tile OOM and on demand ra..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 473813002: Revert 289480 "Still produce quad when tile OOM and on demand ra..." (Closed)

Created:
6 years, 4 months ago by bartfab (slow)

Modified:
6 years, 4 months ago

Reviewers:
weiliangc

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 289480 "Still produce quad when tile OOM and on demand ra..." This caused failures on the Linux ASan bot: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/6417/steps/cc_unittests/logs/DelegatingRendererWithTileOOM > Still produce quad when tile OOM and on demand raster is not allowed > > When on demand raster is not allowed, when tiles are OOM, checkerboard > or solid color quad should be produced rather than nothing. > > Add a unittest for this exact same scenario. > > BUG=402321 > > Review URL: https://codereview.chromium.org/468983002 TBR=weiliangc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289492

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -70 lines)			Patch
M	trunk/src/cc/layers/picture_layer_impl.cc	View	4 chunks	+1 line, -7 lines	0 comments	Download
M	trunk/src/cc/layers/picture_layer_impl_unittest.cc	View	1 chunk	+0 lines, -60 lines	0 comments	Download
M	trunk/src/cc/resources/tile_manager.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	trunk/src/cc/resources/tile_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

bartfab (slow)

6 years, 4 months ago (2014-08-14 08:31:34 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r289492 (tree was closed).