Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: trunk/src/cc/layers/picture_layer_impl.cc

Issue 473813002: Revert 289480 "Still produce quad when tile OOM and on demand ra..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/cc/layers/picture_layer_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/cc/layers/picture_layer_impl.cc
===================================================================
--- trunk/src/cc/layers/picture_layer_impl.cc (revision 289491)
+++ trunk/src/cc/layers/picture_layer_impl.cc (working copy)
@@ -281,7 +281,6 @@
append_quads_data->visible_content_area +=
visible_geometry_rect.width() * visible_geometry_rect.height();
- bool has_draw_quad = false;
if (*iter && iter->IsReadyToDraw()) {
const ManagedTileState::TileVersion& tile_version =
iter->GetTileVersionForDrawing();
@@ -304,7 +303,6 @@
texture_rect,
iter.texture_size(),
tile_version.contents_swizzled());
- has_draw_quad = true;
break;
}
case ManagedTileState::TileVersion::PICTURE_PILE_MODE: {
@@ -335,7 +333,6 @@
iter->content_rect(),
iter->contents_scale(),
pile_);
- has_draw_quad = true;
break;
}
case ManagedTileState::TileVersion::SOLID_COLOR_MODE: {
@@ -346,13 +343,10 @@
visible_geometry_rect,
tile_version.get_solid_color(),
false);
- has_draw_quad = true;
break;
}
}
- }
-
- if (!has_draw_quad) {
+ } else {
if (draw_checkerboard_for_missing_tiles()) {
CheckerboardDrawQuad* quad =
render_pass->CreateAndAppendDrawQuad<CheckerboardDrawQuad>();
« no previous file with comments | « no previous file | trunk/src/cc/layers/picture_layer_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698