Issue 473783003: Make variable names about |className| in PrivateScriptRunner more consistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 473783003: Make variable names about |className| in PrivateScriptRunner more consistent (Closed)

Created:
6 years, 4 months ago by haraken

Modified:
6 years, 4 months ago

Reviewers:
Jens Widell

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Make variable names about |className| in PrivateScriptRunner more consistent After this CL: - |className| means a class name of a dependency interface (e.g., "Document"). - |scriptClassName| means a class name of the script (e.g., "DocumentXSLT"). BUG=341031 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180261

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -14 lines)			Patch
	M	Source/bindings/core/v8/PrivateScriptRunner.cpp	View	1 2	3 chunks	+10 lines, -10 lines	0 comments	Download
	M	Source/build/scripts/make_private_script_source.py	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/473783003/40001

6 years, 4 months ago (2014-08-14 10:36:13 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-08-14 14:40:18 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (40001) as 180261

Expand Messages | Collapse Messages