Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: Source/build/scripts/make_private_script_source.py

Issue 473783003: Make variable names about |className| in PrivateScriptRunner more consistent (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/PrivateScriptRunner.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/build/scripts/make_private_script_source.py
diff --git a/Source/build/scripts/make_private_script_source.py b/Source/build/scripts/make_private_script_source.py
index 32db177251ceded1014f28752dd8a77f8f5bbdca..8064ae710121deaeadae34f7fbb517778f441e9b 100644
--- a/Source/build/scripts/make_private_script_source.py
+++ b/Source/build/scripts/make_private_script_source.py
@@ -46,8 +46,8 @@ def main():
class_name, ', '.join(hex_values)))
contents.append('struct %s {' % source_name)
contents.append("""
+ const char* scriptClassName;
const char* className;
- const char* dependencyClassName;
const unsigned char* source;
size_t size;
};
@@ -55,9 +55,9 @@ def main():
""")
contents.append('struct %s k%s[] = {\n' % (source_name, source_name))
for input_filename in input_filenames:
- class_name, ext = os.path.splitext(os.path.basename(input_filename))
- dependency_class_name = extract_partial_interface_name(input_filename) or class_name
- contents.append(' { "%s", "%s", kSourceOf%s, sizeof(kSourceOf%s) },\n' % (class_name, dependency_class_name, class_name, class_name))
+ script_class_name, ext = os.path.splitext(os.path.basename(input_filename))
+ class_name = extract_partial_interface_name(input_filename) or script_class_name
+ contents.append(' { "%s", "%s", kSourceOf%s, sizeof(kSourceOf%s) },\n' % (script_class_name, class_name, script_class_name, script_class_name))
contents.append('};\n')
with open(output_filename, 'w') as output_file:
« no previous file with comments | « Source/bindings/core/v8/PrivateScriptRunner.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698