Source/modules/serviceworkers/ServiceWorkerRegistration.h - Issue 473743002: ServiceWorker: register() should return the existing registration object if available

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerRegistration.h

Issue 473743002: ServiceWorker: register() should return the existing registration object if available (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/serviceworkers/ServiceWorkerRegistration.h

diff --git a/Source/modules/serviceworkers/ServiceWorkerRegistration.h b/Source/modules/serviceworkers/ServiceWorkerRegistration.h

index 903657f8e76312335574948b2fb7b2c86b210243..12c6a466c5ee0c1edd167ef279dcc40edffb1c88 100644

--- a/Source/modules/serviceworkers/ServiceWorkerRegistration.h

+++ b/Source/modules/serviceworkers/ServiceWorkerRegistration.h

@@ -60,7 +60,7 @@ public:

virtual void trace(Visitor*) OVERRIDE;

private:

- static PassRefPtrWillBeRawPtr<ServiceWorkerRegistration> create(ExecutionContext*, PassOwnPtr<WebServiceWorkerRegistration>);

+ static PassRefPtrWillBeRawPtr<ServiceWorkerRegistration> getOrCreate(ExecutionContext*, PassOwnPtr<WebServiceWorkerRegistration>);

ServiceWorkerRegistration(ExecutionContext*, PassOwnPtr<WebServiceWorkerRegistration>);

OwnPtr<WebServiceWorkerRegistration> m_outerRegistration;

« no previous file with comments | « no previous file | Source/modules/serviceworkers/ServiceWorkerRegistration.cpp » ('j') | public/platform/WebServiceWorkerRegistrationProxy.h » ('J')