Source/modules/serviceworkers/ServiceWorkerRegistration.h - Issue 473743002: ServiceWorker: register() should return the existing registration object if available

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/serviceworkers/ServiceWorkerRegistration.h

Issue 473743002: ServiceWorker: register() should return the existing registration object if available (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | Source/modules/serviceworkers/ServiceWorkerRegistration.cpp » ('j') | public/platform/WebServiceWorkerRegistrationProxy.h » ('J')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef ServiceWorkerRegistration_h	5 #ifndef ServiceWorkerRegistration_h

6 #define ServiceWorkerRegistration_h	6 #define ServiceWorkerRegistration_h

7	7

8 #include "core/dom/ActiveDOMObject.h"	8 #include "core/dom/ActiveDOMObject.h"

9 #include "core/events/EventTarget.h"	9 #include "core/events/EventTarget.h"

10 #include "modules/serviceworkers/ServiceWorker.h"	10 #include "modules/serviceworkers/ServiceWorker.h"

(...skipping 42 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
53	53

54 String scope() const;	54 String scope() const;

55	55

56 ScriptPromise unregister(ScriptState*);	56 ScriptPromise unregister(ScriptState*);

57	57

58 DEFINE_ATTRIBUTE_EVENT_LISTENER(updatefound);	58 DEFINE_ATTRIBUTE_EVENT_LISTENER(updatefound);

59	59

60 virtual void trace(Visitor*) OVERRIDE;	60 virtual void trace(Visitor*) OVERRIDE;

61	61

62 private:	62 private:

63 static PassRefPtrWillBeRawPtr<ServiceWorkerRegistration> create(ExecutionCon text*, PassOwnPtr<WebServiceWorkerRegistration>);	63 static PassRefPtrWillBeRawPtr<ServiceWorkerRegistration> getOrCreate(Executi onContext*, PassOwnPtr<WebServiceWorkerRegistration>);

64 ServiceWorkerRegistration(ExecutionContext*, PassOwnPtr<WebServiceWorkerRegi stration>);	64 ServiceWorkerRegistration(ExecutionContext*, PassOwnPtr<WebServiceWorkerRegi stration>);

65	65

66 OwnPtr<WebServiceWorkerRegistration> m_outerRegistration;	66 OwnPtr<WebServiceWorkerRegistration> m_outerRegistration;

67 WebServiceWorkerProvider* m_provider;	67 WebServiceWorkerProvider* m_provider;

68 RefPtrWillBeMember<ServiceWorker> m_installing;	68 RefPtrWillBeMember<ServiceWorker> m_installing;

69 RefPtrWillBeMember<ServiceWorker> m_waiting;	69 RefPtrWillBeMember<ServiceWorker> m_waiting;

70 RefPtrWillBeMember<ServiceWorker> m_active;	70 RefPtrWillBeMember<ServiceWorker> m_active;

71 };	71 };

72	72

73 } // namespace blink	73 } // namespace blink

74	74

75 #endif // ServiceWorkerRegistration_h	75 #endif // ServiceWorkerRegistration_h

OLD	NEW