[Local NTP] Implementing Material Design styling

[Local NTP] Implementing Material Design styling

We also want the "classical" NTP to coexist with the new design, and
switchable via Finch. Key changes:
- Adding classes to #ntp-content, then using CSS to control styling.
  - .classical for old NTP
  - .md for Material Design
  - .default-theme for values that will be overriden by themes. This is
    needed so dynamic CSS changes in setCustomThemeStyle() are not
    subsumed by specialized .classical and .md.
  - .dark: for dark background.
- The .mv-mask <div> is promoted to handle tile effects, including
  border, shadow, and background. Borders are drawn differently now.
  This lead to fix of 1px offset of .mv-title .

Some new designs are still in flux. Our goal is to get a reasonable bulk
committed for m38, then worry about some tune-ups later.

TEST=Run "chrome.exe --force-fieldtrials=MaterialDesignNTP/Enabled/",
visit chrome-search://local-ntp/local-ntp.html . If chrome.exe is run
without the switch, the local NTP should be identical to before, except
for 1px .mv-title shift.

BUG=400332
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289682

[huangs, 2014-08-13 19:38:55]

Preliminary upload for early feedback.

We will see more style changes and assets, but I prefer to have those as
separate CL.

This contains also contains overlapping changes from
https://codereview.chromium.org/472533002/ . These will be excluded later (so
ignore the .cc, .h, and .grd files).

[Mathieu, 2014-08-13 20:09:30]

Looks mostly good!

https://codereview.chromium.org/473583002/diff/1/chrome/browser/resources/loc...
File chrome/browser/resources/local_ntp/local_ntp.js (right):

https://codereview.chromium.org/473583002/diff/1/chrome/browser/resources/loc...
chrome/browser/resources/local_ntp/local_ntp.js:311: function
getIsBackgroundDark(info) {
rename to isThemeBackgroundDark?

https://codereview.chromium.org/473583002/diff/1/chrome/browser/resources/loc...
chrome/browser/resources/local_ntp/local_ntp.js:993:
NTP_DESIGN.classToAdd.forEach(function(v, idx) {
would rather not have this.

https://codereview.chromium.org/473583002/diff/1/chrome/browser/resources/loc...
File chrome/browser/resources/local_ntp/local_ntp_design.js (right):

https://codereview.chromium.org/473583002/diff/1/chrome/browser/resources/loc...
chrome/browser/resources/local_ntp/local_ntp_design.js:7: * @fileoverview
Specifications for NTP design, and an acessor to presets.
*accessor

https://codereview.chromium.org/473583002/diff/1/chrome/browser/resources/loc...
chrome/browser/resources/local_ntp/local_ntp_design.js:32: * thumbnailFallback:
(Optional) Specifies how to do fallback should be handled
rephrase comment

https://codereview.chromium.org/473583002/diff/1/chrome/browser/resources/loc...
chrome/browser/resources/local_ntp/local_ntp_design.js:65: opt_name ===
'smallScreen2') {
you don't seem to be using smallScreen2, remove?

https://codereview.chromium.org/473583002/diff/1/chrome/browser/resources/loc...
chrome/browser/resources/local_ntp/local_ntp_design.js:81: 
remove extra newline

https://codereview.chromium.org/473583002/diff/1/chrome/browser/resources/loc...
File chrome/browser/resources/local_ntp/most_visited_thumbnail.js (right):

https://codereview.chromium.org/473583002/diff/1/chrome/browser/resources/loc...
chrome/browser/resources/local_ntp/most_visited_thumbnail.js:52: if (!params.tfb
&& data.domain) {
handle this param better

https://codereview.chromium.org/473583002/diff/1/chrome/browser/search/local_...
File chrome/browser/search/local_ntp_source.cc (right):

https://codereview.chromium.org/473583002/diff/1/chrome/browser/search/local_...
chrome/browser/search/local_ntp_source.cc:193: IsMaterialDesignEnabled() ?
kMaterialDesignNTPName : "",
Change/use this here.

[huangs, 2014-08-13 21:34:09]

Updated, PTAL!

https://codereview.chromium.org/473583002/diff/1/chrome/browser/resources/loc...
File chrome/browser/resources/local_ntp/local_ntp.js (right):

https://codereview.chromium.org/473583002/diff/1/chrome/browser/resources/loc...
chrome/browser/resources/local_ntp/local_ntp.js:311: function
getIsBackgroundDark(info) {
Inlined this into renderTheme(), since predominately we use the variable
isBackgroundDark.

https://codereview.chromium.org/473583002/diff/1/chrome/browser/resources/loc...
chrome/browser/resources/local_ntp/local_ntp.js:993:
NTP_DESIGN.classToAdd.forEach(function(v, idx) {
Deleted; injecting "classical" from local_ntp_source.cc to do this.

https://codereview.chromium.org/473583002/diff/1/chrome/browser/resources/loc...
File chrome/browser/resources/local_ntp/local_ntp_design.js (right):

https://codereview.chromium.org/473583002/diff/1/chrome/browser/resources/loc...
chrome/browser/resources/local_ntp/local_ntp_design.js:7: * @fileoverview
Specifications for NTP design, and an acessor to presets.
On 2014/08/13 20:09:30, Mathieu Perreault wrote:
> *accessor

Done.

https://codereview.chromium.org/473583002/diff/1/chrome/browser/resources/loc...
chrome/browser/resources/local_ntp/local_ntp_design.js:32: * thumbnailFallback:
(Optional) Specifies how to do fallback should be handled
On 2014/08/13 20:09:29, Mathieu Perreault wrote:
> rephrase comment

Done.

https://codereview.chromium.org/473583002/diff/1/chrome/browser/resources/loc...
chrome/browser/resources/local_ntp/local_ntp_design.js:65: opt_name ===
'smallScreen2') {
On 2014/08/13 20:09:29, Mathieu Perreault wrote:
> you don't seem to be using smallScreen2, remove?

Done.

https://codereview.chromium.org/473583002/diff/1/chrome/browser/resources/loc...
chrome/browser/resources/local_ntp/local_ntp_design.js:81: 
On 2014/08/13 20:09:29, Mathieu Perreault wrote:
> remove extra newline

Done.

https://codereview.chromium.org/473583002/diff/1/chrome/browser/resources/loc...
File chrome/browser/resources/local_ntp/most_visited_thumbnail.js (right):

https://codereview.chromium.org/473583002/diff/1/chrome/browser/resources/loc...
chrome/browser/resources/local_ntp/most_visited_thumbnail.js:52: if (!params.tfb
&& data.domain) {
Calling this etfb and adding comments.  Note that we only check for its
existence, so we're not sanitizing its values.  Also, this is not assigned in
style because this file actually delegates all style-related stuff in
most_likely_util.js.

https://codereview.chromium.org/473583002/diff/1/chrome/browser/search/local_...
File chrome/browser/search/local_ntp_source.cc (right):

https://codereview.chromium.org/473583002/diff/1/chrome/browser/search/local_...
chrome/browser/search/local_ntp_source.cc:193: IsMaterialDesignEnabled() ?
kMaterialDesignNTPName : "",
On 2014/08/13 20:09:30, Mathieu Perreault wrote:
> Change/use this here.

Done.

[huangs, 2014-08-13 22:06:11]

+jered@

[Mathieu, 2014-08-14 15:05:39]

lgtm if the CSS looks like your circulated demo

https://codereview.chromium.org/473583002/diff/40001/chrome/browser/browser_r...
File chrome/browser/browser_resources.grd (right):

https://codereview.chromium.org/473583002/diff/40001/chrome/browser/browser_r...
chrome/browser/browser_resources.grd:217: <include name="IDR_ROBOTO_WOFF"
file="resources\roboto\roboto.woff" type="BINDATA" />
re-add is_android

https://codereview.chromium.org/473583002/diff/40001/chrome/browser/search/lo...
File chrome/browser/search/local_ntp_source.cc (right):

https://codereview.chromium.org/473583002/diff/40001/chrome/browser/search/lo...
chrome/browser/search/local_ntp_source.cc:39: // Name to be used for the new
design in local resources.
update comment

[huangs, 2014-08-14 15:50:21]

Thanks. Submitting!

https://codereview.chromium.org/473583002/diff/40001/chrome/browser/browser_r...
File chrome/browser/browser_resources.grd (right):

https://codereview.chromium.org/473583002/diff/40001/chrome/browser/browser_r...
chrome/browser/browser_resources.grd:217: <include name="IDR_ROBOTO_WOFF"
file="resources\roboto\roboto.woff" type="BINDATA" />
On 2014/08/14 15:05:39, Mathieu Perreault wrote:
> re-add is_android

Done.

https://codereview.chromium.org/473583002/diff/40001/chrome/browser/search/lo...
File chrome/browser/search/local_ntp_source.cc (right):

https://codereview.chromium.org/473583002/diff/40001/chrome/browser/search/lo...
chrome/browser/search/local_ntp_source.cc:39: // Name to be used for the new
design in local resources.
On 2014/08/14 15:05:39, Mathieu Perreault wrote:
> update comment

Done.

[huangs, 2014-08-14 16:03:57]

The CQ bit was checked by huangs@chromium.org

[commit-bot: I haz the power, 2014-08-14 16:06:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/huangs@chromium.org/473583002/60001

[commit-bot: I haz the power, 2014-08-14 19:22:20]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-08-14 19:58:35]

Committed patchset #4 (60001) as 289682