Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: chrome/browser/resources/local_ntp/local_ntp_design.js

Issue 473583002: [Local NTP] Implementing Material Design styling (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing comments. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/local_ntp/local_ntp_design.js
diff --git a/chrome/browser/resources/local_ntp/local_ntp_design.js b/chrome/browser/resources/local_ntp/local_ntp_design.js
index 59ed11fad10401aa3ba2dfb4063733caf3bc2593..ec8db7311a80bc5e57688e938487d574ac4829ee 100644
--- a/chrome/browser/resources/local_ntp/local_ntp_design.js
+++ b/chrome/browser/resources/local_ntp/local_ntp_design.js
@@ -4,26 +4,33 @@
/**
- * @fileoverview Specifications for the NTP design, and an accessor to presets.
+ * @fileoverview Specifications for NTP design, and an accessor to presets.
*/
+ var THUMBNAIL_FALLBACK = {
+ DOT: 'dot' // Draw single dot.
+ };
/**
* Specifications for an NTP design (not comprehensive).
*
* name: A unique identifier for the style.
- * appropriate CSS will take effect.
* fontFamily: Font family to use for title and thumbnail <iframe>s.
* fontSize: Font size to use for the <iframe>s, in px.
* tileWidth: The width of each suggestion tile, in px.
* tileMargin: Spacing between successive tiles, in px.
* titleColor: The RRGGBB color of title text.
+ * titleColorAgainstDark: The RRGGBB color of title text against a dark theme.
* titleTextAlign: (Optional) The alignment of title text. If unspecified, the
* default value is 'center'.
* titleTextFade: (Optional) The number of pixels beyond which title
* text begins to fade. This overrides the default ellipsis style.
* thumbnailTextColor: The RRGGBB color that thumbnail <iframe> may use to
* display text message in place of missing thumbnail.
+ * thumbnailFallback: (Optional) A value in THUMBNAIL_FALLBACK to specify the
+ * thumbnail fallback strategy. If unassigned, then the thumbnail.html
+ * <iframe> would handle the fallback.
+ * showFakeboxHint: Whether to display text in the fakebox.
*
* @typedef {{
* name: string,
@@ -32,9 +39,12 @@
* tileWidth: number,
* tileMargin: number,
* titleColor: string,
+ * titleColorAgainstDark: string,
* titleTextAlign: string|null|undefined,
* titleTextFade: string|null|undefined,
- * thumbnailTextColor: string
+ * thumbnailTextColor: string,
+ * thumbnailFallback: string|null|undefined
+ * showFakeboxHint: string|null|undefined
* }}
*/
var NtpDesign;
@@ -46,16 +56,38 @@ var NtpDesign;
* @return {NtpDesign} The NTP design corresponding to name.
*/
function getNtpDesign(opt_name) {
- // TODO(huangs): Add new style.
- return {
- name: 'classical',
- fontFamily: 'arial, sans-serif',
- fontSize: 11,
- tileWidth: 140,
- tileMargin: 20,
- titleColor: '777777',
- // No titleTextAlign: defaults to 'center'.
- // No titleTextFade: by default we have ellipsis.
- thumbnailTextColor: '777777'
- };
+ var ntpDesign = null;
+
+ if (opt_name === 'md') {
+ ntpDesign = {
+ name: opt_name,
+ fontFamily: 'arial, sans-serif',
+ fontSize: 12,
+ tileWidth: 146,
+ tileMargin: 12,
+ titleColor: '000000',
+ titleColorAgainstDark: 'd2d2d2',
+ titleTextAlign: 'inherit',
+ titleTextFade: 112 - 24, // 112px wide title with 24 pixel fade at end.
+ thumbnailTextColor: '777777',
+ thumbnailFallback: THUMBNAIL_FALLBACK.DOT,
+ showFakeboxHint: true
+ };
+ } else {
+ ntpDesign = {
+ name: 'classical',
+ fontFamily: 'arial, sans-serif',
+ fontSize: 11,
+ tileWidth: 140,
+ tileMargin: 20,
+ titleColor: '777777',
+ titleColorAgainstDark: '777777',
+ titleTextAlign: 'center',
+ titleTextFade: null, // Default to ellipsis.
+ thumbnailTextColor: '777777',
+ thumbnailFallback: null, // Default to false.
+ showFakeboxHint: false
+ };
+ }
+ return ntpDesign;
}
« no previous file with comments | « chrome/browser/resources/local_ntp/local_ntp.js ('k') | chrome/browser/resources/local_ntp/most_visited_thumbnail.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698