net/proxy/proxy_info.h - Issue 473513002: Keep track of network error in ProxyRetryInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_info.h

Issue 473513002: Keep track of network error in ProxyRetryInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge to head. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/proxy/proxy_info.h

diff --git a/net/proxy/proxy_info.h b/net/proxy/proxy_info.h

index 336cb3a58881c2982f4d1a4b4d10d5e16597cdf7..783ca49666ff5170c89c8f5dac5549d5383d0758 100644

--- a/net/proxy/proxy_info.h

+++ b/net/proxy/proxy_info.h

@@ -117,7 +117,7 @@ class NET_EXPORT ProxyInfo {

// Marks the current proxy as bad. Returns true if there is another proxy

// available to try in proxy list_.

- bool Fallback(const BoundNetLog& net_log);

+ bool Fallback(const int net_error, const BoundNetLog& net_log);

Ryan Sleevi 2014/08/15 00:02:23 no const

Not at Google. Contact bengr 2014/08/15 17:26:59 Done. Removed from .cc as well.

// De-prioritizes the proxies that we have cached as not working, by moving

// them to the end of the proxy list.