Keep track of network error in ProxyRetryInfo.

net/base/network_delegate.h

Index: net/base/network_delegate.h
diff --git a/net/base/network_delegate.h b/net/base/network_delegate.h
index 2a0c9f0a172cbef91e896c4d72c5e94ac9d6e416..a032f7b2db56bb72b899e953bfbf1c09389c7433 100644
--- a/net/base/network_delegate.h
+++ b/net/base/network_delegate.h
@@ -68,8 +68,7 @@ class NET_EXPORT NetworkDelegate : public base::NonThreadSafe {
                           const ProxyService& proxy_service,
                           ProxyInfo* result);
   void NotifyProxyFallback(const ProxyServer& bad_proxy,
-                           int net_error,
-                           bool did_fallback);
+                                   int net_error);

[Ryan Sleevi, 2014/08/15 00:02:23]

format.

[Not at Google. Contact bengr, 2014/08/15 17:26:59]

Done.

   int NotifyBeforeSendHeaders(URLRequest* request,
                               const CompletionCallback& callback,
                               HttpRequestHeaders* headers);
@@ -138,12 +137,11 @@ class NET_EXPORT NetworkDelegate : public base::NonThreadSafe {
                               const ProxyService& proxy_service,
                               ProxyInfo* result);
 
-  // Called when use of |bad_proxy| fails due to |net_error|. |did_fallback| is
-  // true if the proxy service was able to fallback to another proxy
-  // configuration.
+  // Called when use of |bad_proxy| fails due to |net_error|. |net_error| is
+  // the network error encountered, if any, and OK if the fallback was
+  // for a reason other than network error.

[Ryan Sleevi, 2014/08/15 00:02:23]

What's a reason for fallback OTHER than a network error? (Try to mention it in
terms of NetworkDelegate/ProxyService, rather than if it's specific to data
reduction proxy)

I'm guessing this is something like
"and OK if the fallback was for a reason other than a network error (e.g. a
delegate indicated to try a different proxy)" (I don't know if a delegate can do
that, but that's the sort of level of abstractness)

[Not at Google. Contact bengr, 2014/08/15 17:26:59]

Added clarification. Please check that it provides the right amount of
information.

   virtual void OnProxyFallback(const ProxyServer& bad_proxy,
-                               int net_error,
-                               bool did_fallback);
+                               int net_error);
 
   // Called right before the HTTP headers are sent. Allows the delegate to
   // read/write |headers| before they get sent out. |callback| and |headers| are