net/proxy/proxy_list.h - Issue 473513002: Keep track of network error in ProxyRetryInfo.

Unified Diff: net/proxy/proxy_list.h

Issue 473513002: Keep track of network error in ProxyRetryInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge to head Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/proxy/proxy_list.h

diff --git a/net/proxy/proxy_list.h b/net/proxy/proxy_list.h

index ac9635a977acbb173d3a1059370159ac071c5dd7..10d57eaeafbde4d1b7f8f47c380ffbc0f2416318 100644

--- a/net/proxy/proxy_list.h

+++ b/net/proxy/proxy_list.h

@@ -82,6 +82,7 @@ class NET_EXPORT_PRIVATE ProxyList {

// list of known bad proxies is given by proxy_retry_info. Returns true if

// there is another server available in the list.

Ryan Sleevi 2014/08/14 21:14:39 Add a param = update comments

Not at Google. Contact bengr 2014/08/14 23:45:22 Done. Took me a little while to figure out what yo

bool Fallback(ProxyRetryInfoMap* proxy_retry_info,

+ const int net_error,

const BoundNetLog& net_log);

// Updates |proxy_retry_info| to indicate that the first proxy in the list

@@ -96,6 +97,7 @@ class NET_EXPORT_PRIVATE ProxyList {

base::TimeDelta retry_delay,

bool reconsider,

const ProxyServer& another_proxy_to_bypass,

+ const int net_error,

Ryan Sleevi 2014/08/14 21:14:39 Add a param = update comments also, no const

Not at Google. Contact bengr 2014/08/14 23:45:22 Done. Removed const from net_error everywhere. Ca

Ryan Sleevi 2014/08/14 23:54:03 It's an int. It's always passed by value. Making i

Not at Google. Contact bengr 2014/08/14 23:59:58 It does enforce that the value will not change wit

const BoundNetLog& net_log) const;

private:

@@ -106,6 +108,7 @@ class NET_EXPORT_PRIVATE ProxyList {

base::TimeDelta retry_delay,

bool try_while_bad,

const ProxyServer& proxy_to_retry,

+ const int net_error,

Ryan Sleevi 2014/08/14 21:14:39 add a... well, you get the idea :)

Not at Google. Contact bengr 2014/08/14 23:45:22 Done.

const BoundNetLog& net_log) const;

// List of proxies.