Keep track of network error in ProxyRetryInfo.

net/proxy/proxy_list.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_PROXY_PROXY_LIST_H_
 #define NET_PROXY_PROXY_LIST_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 62 matching lines @@
 
   // Returns a PAC-style semicolon-separated list of valid proxy servers.
   // For example: "PROXY xxx.xxx.xxx.xxx:xx; SOCKS yyy.yyy.yyy:yy".
   std::string ToPacString() const;
 
   // Returns a serialized value for the list. The caller takes ownership of it.
   base::ListValue* ToValue() const;
 
   // Marks the current proxy server as bad and deletes it from the list.  The
   // list of known bad proxies is given by proxy_retry_info.  Returns true if
   // there is another server available in the list.

[Ryan Sleevi, 2014/08/14 21:14:39]

Add a param = update comments

[Not at Google. Contact bengr, 2014/08/14 23:45:22]

Done. Took me a little while to figure out what you meant:)

   bool Fallback(ProxyRetryInfoMap* proxy_retry_info,
+                const int net_error,
                 const BoundNetLog& net_log);
 
   // Updates |proxy_retry_info| to indicate that the first proxy in the list
   // is bad. This is distinct from Fallback(), above, to allow updating proxy
   // retry information without modifying a given transction's proxy list. Will
   // retry after |retry_delay| if positive, and will use the default proxy retry
   // duration otherwise. It may reconsider the proxy beforehand if |reconsider|
   // is true. Additionally updates |proxy_retry_info| with
   // |another_proxy_to_bypass| if non-empty.
   void UpdateRetryInfoOnFallback(
       ProxyRetryInfoMap* proxy_retry_info,
       base::TimeDelta retry_delay,
       bool reconsider,
       const ProxyServer& another_proxy_to_bypass,
+      const int net_error,

[Ryan Sleevi, 2014/08/14 21:14:39]

Add a param = update comments

also, no const

[Not at Google. Contact bengr, 2014/08/14 23:45:22]

Done.

Removed const from net_error everywhere. Can you please clarify why I should not
use const here. Did not see anything in the style guide about this.

[Ryan Sleevi, 2014/08/14 23:54:03]

It's an int. It's always passed by value. Making it const doesn't really buy you
anything, API contract wise.

[Not at Google. Contact bengr, 2014/08/14 23:59:58]

It does enforce that the value will not change within the method. Some codebases
within Google enforce that anything that can be marked with const, must be. I
personally don't feel strongly one way or the other.

       const BoundNetLog& net_log) const;
 
  private:
   // Updates |proxy_retry_info| to indicate that the |proxy_to_retry| in
   // |proxies_| is bad for |retry_delay|, but may be reconsidered earlier if
   // |try_while_bad| is true.
   void AddProxyToRetryList(ProxyRetryInfoMap* proxy_retry_info,
                            base::TimeDelta retry_delay,
                            bool try_while_bad,
                            const ProxyServer& proxy_to_retry,
+                           const int net_error,

[Ryan Sleevi, 2014/08/14 21:14:39]

add a... well, you get the idea :)

[Not at Google. Contact bengr, 2014/08/14 23:45:22]

Done.

                            const BoundNetLog& net_log) const;
 
   // List of proxies.
   std::vector<ProxyServer> proxies_;
 };
 
 }  // namespace net
 
 #endif  // NET_PROXY_PROXY_LIST_H_