Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 473423005: Revert of Hook up the Mac password bubble to the browser and add browser tests. (Closed)

Created:
6 years, 4 months ago by jam
Modified:
6 years, 3 months ago
CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Hook up the Mac password bubble to the browser and add browser tests. (patchset #8 of https://codereview.chromium.org/444603003/) Reason for revert: the browser tests this added are really flaky on the trybots. see http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6541 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6582 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6576 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6574 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6573 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6572 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6567 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6566 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6565 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6564 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6561 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6557 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6556 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6554 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6554 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6549 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6548 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6544 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6544 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6541 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6539 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6537 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6530 please test this on many try runs before relanding. Original issue's description: > Hook up the Mac password bubble to the browser and add browser tests. > > BUG=328847 > > Committed: https://chromium.googlesource.com/chromium/src/+/dae2a9adff280655fa9261b972fd62ae837b374d TBR=dconnelly NOTRY=true Committed: https://crrev.com/e8e38740e5ab846889016636024309473c04dedd Cr-Commit-Position: refs/heads/master@{#291755}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -429 lines) Patch
M chrome/browser/password_manager/chrome_password_manager_client.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_dialogs.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 3 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.h View 3 chunks +1 line, -12 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.mm View 5 chunks +5 lines, -23 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration_unittest.mm View 2 chunks +2 lines, -3 lines 0 comments Download
D chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_browsertest.mm View 1 chunk +0 lines, -116 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.h View 3 chunks +2 lines, -15 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa.mm View 3 chunks +3 lines, -35 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_cocoa_unittest.mm View 2 chunks +3 lines, -13 lines 0 comments Download
D chrome/browser/ui/passwords/manage_passwords_test.h View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/ui/passwords/manage_passwords_test.cc View 1 chunk +0 lines, -100 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc View 2 chunks +2 lines, -21 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_icon_view_browsertest.cc View 1 chunk +2 lines, -21 lines 0 comments Download
A chrome/browser/ui/views/passwords/manage_passwords_view_test.h View 1 chunk +60 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/passwords/manage_passwords_view_test.cc View 1 chunk +108 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 4 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jam
Created Revert of Hook up the Mac password bubble to the browser and add browser ...
6 years, 4 months ago (2014-08-25 20:37:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/473423005/1
6 years, 4 months ago (2014-08-25 20:38:42 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-25 20:38:43 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-25 20:38:43 UTC) #4
jam
The CQ bit was checked by jam@chromium.org
6 years, 4 months ago (2014-08-25 20:41:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/473423005/1
6 years, 4 months ago (2014-08-25 20:41:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (1) as eca835c91beb1bf9eb2ef62dad84be80005b8a67
6 years, 4 months ago (2014-08-25 20:43:02 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:37:21 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e8e38740e5ab846889016636024309473c04dedd
Cr-Commit-Position: refs/heads/master@{#291755}

Powered by Google App Engine
This is Rietveld 408576698