chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm - Issue 473423005: Revert of Hook up the Mac password bubble to the browser and add browser tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

Issue 473423005: Revert of Hook up the Mac password bubble to the browser and add browser tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h ('k') | chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

diff --git a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

index d4a4967a7275cec59d6cdcbecfce9d5835cfd646..a2f6d3d7852427d9a44317e9a4e8d8ce2d381cc1 100644

--- a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

+++ b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

@@ -133,7 +133,7 @@

new GeneratedCreditCardDecoration(this)),

search_button_decoration_(new SearchButtonDecoration(this)),

manage_passwords_decoration_(

- new ManagePasswordsDecoration(command_updater, this)),

+ new ManagePasswordsDecoration(command_updater)),

browser_(browser),

weak_ptr_factory_(this) {

for (size_t i = 0; i < CONTENT_SETTINGS_NUM_TYPES; ++i) {

@@ -222,7 +222,6 @@

return;

ManagePasswordsUIController::FromWebContents(web_contents)

->UpdateIconAndBubbleState(manage_passwords_decoration_->icon());

- OnDecorationsChanged();

}

void LocationBarViewMac::UpdatePageActions() {

@@ -527,7 +526,6 @@

}

void LocationBarViewMac::Update(const WebContents* contents) {

- UpdateManagePasswordsIconAndBubble();

UpdateStarDecorationVisibility();

UpdateTranslateDecoration();

UpdateZoomDecoration();