Issue 473313002: Adds handling of 'Found dependency (all)' to filter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 473313002: Adds handling of 'Found dependency (all)' to filter (Closed)

Created:
6 years, 4 months ago by sky

Modified:
6 years, 4 months ago

Reviewers:
iannucci

CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master

Project:
tools

Visibility:
Public.

More Reviews

Description

Adds handling of 'Found dependency (all)' to filter Eventually I'll need to handle this differently, but for now it can be treated as 'Found dependency' BUG=109173 TEST=none R=iannucci@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=289995

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -2 lines)			Patch
M	scripts/slave/recipe_modules/filter/api.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	scripts/slave/recipe_modules/filter/example.py	View	1 chunk	+11 lines, -1 line	0 comments	Download
A	scripts/slave/recipe_modules/filter/example.expected/analyzes_matches_all_exes.json	View	1 chunk	+43 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

iannucci

hmmm... not a fan of the human-readable-strings-as-a-way-to-pass-data-to-a-machine, but lgtm otherwise.

6 years, 4 months ago (2014-08-15 20:05:18 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/473313002/1

6 years, 4 months ago (2014-08-15 20:15:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 289995

Expand Messages | Collapse Messages