Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: scripts/slave/recipe_modules/filter/api.py

Issue 473313002: Adds handling of 'Found dependency (all)' to filter (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/filter/example.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import re 5 import re
6 6
7 from slave import recipe_api 7 from slave import recipe_api
8 8
9 class FilterApi(recipe_api.RecipeApi): 9 class FilterApi(recipe_api.RecipeApi):
10 def __init__(self, **kwargs): 10 def __init__(self, **kwargs):
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 # will fail too, but errors there are more well understood than here. 89 # will fail too, but errors there are more well understood than here.
90 self._result = True 90 self._result = True
91 step_result = f.result 91 step_result = f.result
92 step_result.presentation.status = 'WARNING' 92 step_result.presentation.status = 'WARNING'
93 return 93 return
94 94
95 if 'error' in step_result.json.output: 95 if 'error' in step_result.json.output:
96 self._result = True 96 self._result = True
97 step_result.presentation.step_text = 'Error: ' + \ 97 step_result.presentation.step_text = 'Error: ' + \
98 step_result.json.output['error'] 98 step_result.json.output['error']
99 elif step_result.json.output['status'] == 'Found dependency': 99 elif step_result.json.output['status'] == 'Found dependency' or \
100 step_result.json.output['status'] == 'Found dependency (all)':
100 self._matching_exes = step_result.json.output['targets'] 101 self._matching_exes = step_result.json.output['targets']
101 self._result = True 102 self._result = True
102 else: 103 else:
103 step_result.presentation.step_text = 'No compile necessary' 104 step_result.presentation.step_text = 'No compile necessary'
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/filter/example.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698