Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 473163002: Oilpan: fix use of uninitialized raw pointers on the stack. (Closed)

Created:
6 years, 4 months ago by Mads Ager (chromium)
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Project:
blink
Visibility:
Public.

Description

Oilpan: fix use of uninitialized raw pointers on the stack. These are crashing on layout tests in the oilpan build. The reason is that with oilpan these are just raw pointers and are therefore not default initialized to null. R=haraken@chromium.org, oilpan-reviews@chromium.org, timloh@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180340

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mads Ager (chromium)
6 years, 4 months ago (2014-08-15 07:23:23 UTC) #1
zerny-chromium
lgtm
6 years, 4 months ago (2014-08-15 07:24:07 UTC) #2
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 4 months ago (2014-08-15 07:24:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/473163002/1
6 years, 4 months ago (2014-08-15 07:24:59 UTC) #4
haraken
LGTM
6 years, 4 months ago (2014-08-15 07:34:51 UTC) #5
sof
lgtm (verified that were no other occurrences in this file.)
6 years, 4 months ago (2014-08-15 07:36:01 UTC) #6
Timothy Loh
On 2014/08/15 07:23:23, Mads Ager (chromium) wrote: Sorry about that, lgtm.
6 years, 4 months ago (2014-08-15 07:41:32 UTC) #7
Mads Ager (chromium)
On 2014/08/15 at 07:41:32, timloh wrote: > On 2014/08/15 07:23:23, Mads Ager (chromium) wrote: > ...
6 years, 4 months ago (2014-08-15 08:10:29 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 08:35:21 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (1) as 180340

Powered by Google App Engine
This is Rietveld 408576698