Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 473163002: Oilpan: fix use of uninitialized raw pointers on the stack. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com> 5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved. 8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
9 * Copyright (C) 2012 Intel Corporation. All rights reserved. 9 * Copyright (C) 2012 Intel Corporation. All rights reserved.
10 * 10 *
(...skipping 3114 matching lines...) Expand 10 before | Expand all | Expand 10 after
3125 return cssValuePool().createIdentifierValue(result); 3125 return cssValuePool().createIdentifierValue(result);
3126 if (equalIgnoringCase(value, "none")) 3126 if (equalIgnoringCase(value, "none"))
3127 return cssValuePool().createIdentifierValue(CSSValueNone); 3127 return cssValuePool().createIdentifierValue(CSSValueNone);
3128 if (equalIgnoringCase(value, "inherit") || equalIgnoringCase(value, "initial ")) 3128 if (equalIgnoringCase(value, "inherit") || equalIgnoringCase(value, "initial "))
3129 return nullptr; 3129 return nullptr;
3130 return createPrimitiveStringValue(value); 3130 return createPrimitiveStringValue(value);
3131 } 3131 }
3132 3132
3133 bool CSSPropertyParser::parseWebkitTransformOriginShorthand(bool important) 3133 bool CSSPropertyParser::parseWebkitTransformOriginShorthand(bool important)
3134 { 3134 {
3135 RefPtrWillBeRawPtr<CSSValue> originX; 3135 RefPtrWillBeRawPtr<CSSValue> originX = nullptr;
3136 RefPtrWillBeRawPtr<CSSValue> originY; 3136 RefPtrWillBeRawPtr<CSSValue> originY = nullptr;
3137 RefPtrWillBeRawPtr<CSSValue> originZ; 3137 RefPtrWillBeRawPtr<CSSValue> originZ = nullptr;
3138 3138
3139 parse2ValuesFillPosition(m_valueList.get(), originX, originY); 3139 parse2ValuesFillPosition(m_valueList.get(), originX, originY);
3140 3140
3141 if (m_valueList->current()) { 3141 if (m_valueList->current()) {
3142 if (!validUnit(m_valueList->current(), FLength)) 3142 if (!validUnit(m_valueList->current(), FLength))
3143 return false; 3143 return false;
3144 originZ = createPrimitiveNumericValue(m_valueList->current()); 3144 originZ = createPrimitiveNumericValue(m_valueList->current());
3145 m_valueList->next(); 3145 m_valueList->next();
3146 } else { 3146 } else {
3147 originZ = cssValuePool().createImplicitInitialValue(); 3147 originZ = cssValuePool().createImplicitInitialValue();
(...skipping 5341 matching lines...) Expand 10 before | Expand all | Expand 10 after
8489 parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueFill)); 8489 parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueFill));
8490 if (!seenStroke) 8490 if (!seenStroke)
8491 parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueStroke) ); 8491 parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueStroke) );
8492 if (!seenMarkers) 8492 if (!seenMarkers)
8493 parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueMarkers )); 8493 parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueMarkers ));
8494 8494
8495 return parsedValues.release(); 8495 return parsedValues.release();
8496 } 8496 }
8497 8497
8498 } // namespace blink 8498 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698