DevTools: Get rid of module initializers in the source tree

DevTools: Get rid of module initializers in the source tree

The _module.js files are currently used only at build-time in the
release mode and at run-time when starting workers.
We have all the required module info in module.json files,
and workers can be loaded in the debug mode through a blob containing
concatenated scripts for the worker, loaded via sync XHRs.
This patch also gets rid of common/modules.js: module descriptors
are now inlined into Runtime.js.

R=pfeldman, vsevik
BUG=391566
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180452

[vsevik, 2014-08-14 16:43:47]

https://chromiumcodereview.appspot.com/472903003/diff/20001/Source/devtools/f...
File Source/devtools/front_end/Runtime.js (right):

https://chromiumcodereview.appspot.com/472903003/diff/20001/Source/devtools/f...
Source/devtools/front_end/Runtime.js:124: var blob = new Blob([workerString], {
type: "text/javascript" });
This will make debugging workers harder since all of the scripts are
concatenated.
As discussed offline let's use postMessage/eval technique instead.

[apavlov, 2014-08-15 13:09:10]

PTAL

[eustas, 2014-08-15 13:22:27]

https://codereview.chromium.org/472903003/diff/40001/Source/devtools/front_en...
File Source/devtools/front_end/Runtime.js (right):

https://codereview.chromium.org/472903003/diff/40001/Source/devtools/front_en...
Source/devtools/front_end/Runtime.js:32: var _importedScripts = {};
Is it still "imported" scripts?

[apavlov, 2014-08-15 13:31:44]

https://codereview.chromium.org/472903003/diff/40001/Source/devtools/front_en...
File Source/devtools/front_end/Runtime.js (right):

https://codereview.chromium.org/472903003/diff/40001/Source/devtools/front_en...
Source/devtools/front_end/Runtime.js:32: var _importedScripts = {};
On 2014/08/15 13:22:26, eustas wrote:
> Is it still "imported" scripts?

Can be renamed _loadedScripts

[lushnikov, 2014-08-15 14:23:13]

https://codereview.chromium.org/472903003/diff/60001/Source/devtools/front_en...
File Source/devtools/front_end/Runtime.js (right):

https://codereview.chromium.org/472903003/diff/60001/Source/devtools/front_en...
Source/devtools/front_end/Runtime.js:31: var allDescriptors = [];
let's clarify how/when it gets some values

https://codereview.chromium.org/472903003/diff/60001/Source/devtools/front_en...
Source/devtools/front_end/Runtime.js:169: var workerJSON = JSON.parse(content);
lets inline

https://codereview.chromium.org/472903003/diff/60001/Source/devtools/front_en...
Source/devtools/front_end/Runtime.js:175: url: self._importScriptPathPrefix +
moduleName + "/" + scripts[i]
lets normalize path here

https://codereview.chromium.org/472903003/diff/60001/Source/devtools/front_en...
Source/devtools/front_end/Runtime.js:182: window.URL.revokeObjectURL(workerURL);
lets do this in finally to not leak memory

https://codereview.chromium.org/472903003/diff/60001/Source/devtools/front_en...
Source/devtools/front_end/Runtime.js:505: if (allDescriptors.length) {
lets introduce isRelease() on Runtime

https://codereview.chromium.org/472903003/diff/60001/Source/devtools/scripts/...
File Source/devtools/scripts/concatenate_module_scripts.py (right):

https://codereview.chromium.org/472903003/diff/60001/Source/devtools/scripts/...
Source/devtools/scripts/concatenate_module_scripts.py:39: if
path.exists(filename):
lets add comment regarding hardlink

https://codereview.chromium.org/472903003/diff/60001/Source/devtools/scripts/...
Source/devtools/scripts/concatenate_module_scripts.py:49: if not
path.isfile(file_path):
lets clarify this

https://codereview.chromium.org/472903003/diff/60001/Source/devtools/scripts/...
Source/devtools/scripts/concatenate_module_scripts.py:75: if scripts:
assert(scripts)

[apavlov, 2014-08-15 14:54:46]

https://codereview.chromium.org/472903003/diff/60001/Source/devtools/front_en...
File Source/devtools/front_end/Runtime.js (right):

https://codereview.chromium.org/472903003/diff/60001/Source/devtools/front_en...
Source/devtools/front_end/Runtime.js:31: var allDescriptors = [];
On 2014/08/15 14:23:13, lushnikov wrote:
> let's clarify how/when it gets some values

Done.

https://codereview.chromium.org/472903003/diff/60001/Source/devtools/front_en...
Source/devtools/front_end/Runtime.js:169: var workerJSON = JSON.parse(content);
On 2014/08/15 14:23:13, lushnikov wrote:
> lets inline

Done.

https://codereview.chromium.org/472903003/diff/60001/Source/devtools/front_en...
Source/devtools/front_end/Runtime.js:175: url: self._importScriptPathPrefix +
moduleName + "/" + scripts[i]
On 2014/08/15 14:23:13, lushnikov wrote:
> lets normalize path here

Done.

https://codereview.chromium.org/472903003/diff/60001/Source/devtools/front_en...
Source/devtools/front_end/Runtime.js:182: window.URL.revokeObjectURL(workerURL);
On 2014/08/15 14:23:13, lushnikov wrote:
> lets do this in finally to not leak memory

Done.

https://codereview.chromium.org/472903003/diff/60001/Source/devtools/front_en...
Source/devtools/front_end/Runtime.js:505: if (allDescriptors.length) {
On 2014/08/15 14:23:13, lushnikov wrote:
> lets introduce isRelease() on Runtime

Done.

https://codereview.chromium.org/472903003/diff/60001/Source/devtools/scripts/...
File Source/devtools/scripts/concatenate_module_scripts.py (right):

https://codereview.chromium.org/472903003/diff/60001/Source/devtools/scripts/...
Source/devtools/scripts/concatenate_module_scripts.py:39: if
path.exists(filename):
On 2014/08/15 14:23:13, lushnikov wrote:
> lets add comment regarding hardlink

Done.

https://codereview.chromium.org/472903003/diff/60001/Source/devtools/scripts/...
Source/devtools/scripts/concatenate_module_scripts.py:49: if not
path.isfile(file_path):
On 2014/08/15 14:23:13, lushnikov wrote:
> lets clarify this

Done.

https://codereview.chromium.org/472903003/diff/60001/Source/devtools/scripts/...
Source/devtools/scripts/concatenate_module_scripts.py:75: if scripts:
On 2014/08/15 14:23:13, lushnikov wrote:
> assert(scripts)

Done.

[lushnikov, 2014-08-16 14:18:29]

lgtm

[apavlov, 2014-08-18 11:16:14]

The CQ bit was checked by apavlov@chromium.org

[commit-bot: I haz the power, 2014-08-18 11:17:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/apavlov@chromium.org/472903003/100001

[apavlov, 2014-08-18 11:22:21]

The CQ bit was unchecked by apavlov@chromium.org

[vsevik, 2014-08-18 12:04:31]

https://codereview.chromium.org/472903003/diff/100001/Source/devtools/front_e...
File Source/devtools/front_end/Runtime.js (right):

https://codereview.chromium.org/472903003/diff/100001/Source/devtools/front_e...
Source/devtools/front_end/Runtime.js:162: if (!content)
We'd better do console.error and silently return instead.

https://codereview.chromium.org/472903003/diff/100001/Source/devtools/front_e...
Source/devtools/front_end/Runtime.js:196: } finally {
I don't think we actually care about revoking object URL in case the code above
throws.

[vsevik, 2014-08-18 12:07:20]

lgtm

[apavlov, 2014-08-18 12:21:44]

https://codereview.chromium.org/472903003/diff/100001/Source/devtools/front_e...
File Source/devtools/front_end/Runtime.js (right):

https://codereview.chromium.org/472903003/diff/100001/Source/devtools/front_e...
Source/devtools/front_end/Runtime.js:162: if (!content)
On 2014/08/18 12:04:31, vsevik wrote:
> We'd better do console.error and silently return instead.

Since we return a Worker instance, we'll have to check/cast the result in all
the call sites. The current version is a quick-and-dirty solution for the
debug_devtools=1 scenario.

https://codereview.chromium.org/472903003/diff/100001/Source/devtools/front_e...
Source/devtools/front_end/Runtime.js:196: } finally {
On 2014/08/18 12:04:31, vsevik wrote:
> I don't think we actually care about revoking object URL in case the code
above
> throws.

lushnikov@ asked for this. Anyway, this seems like a good surefire way out.

[apavlov, 2014-08-18 12:21:55]

The CQ bit was checked by apavlov@chromium.org

[commit-bot: I haz the power, 2014-08-18 12:22:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/apavlov@chromium.org/472903003/100001

[commit-bot: I haz the power, 2014-08-18 12:23:42]

Committed patchset #6 (100001) as 180452