DevTools: Get rid of module initializers in the source tree

Source/devtools/scripts/compile_frontend.py

 #!/usr/bin/env python
 # Copyright (c) 2012 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
@@ skipping 69 matching lines @@
 
 type_checked_jsdoc_tags_list = ["param", "return", "type", "enum"]
 
 type_checked_jsdoc_tags_or = "|".join(type_checked_jsdoc_tags_list)
 
 # Basic regex for invalid JsDoc types: an object type name ([A-Z][A-Za-z0-9.]+[A-Za-z0-9]) not preceded by '!', '?', ':' (this, new), or '.' (object property).
 invalid_type_regex = re.compile(r"@(?:" + type_checked_jsdoc_tags_or + r")\s*\{.*(?<![!?:.A-Za-z0-9])([A-Z][A-Za-z0-9.]+[A-Za-z0-9])[^/]*\}")
 
 invalid_type_designator_regex = re.compile(r"@(?:" + type_checked_jsdoc_tags_or + r")\s*.*(?<![{: ])([?!])=?\}")
 
-importscript_regex = re.compile(r"importScript\(\s*[\"']")
 error_warning_regex = re.compile(r"(?:WARNING|ERROR)")
 
 errors_found = False
 
 
 def run_in_shell(command_line):
     return subprocess.Popen(command_line, stdout=subprocess.PIPE, stderr=subprocess.STDOUT, shell=True)
 
 
 def hasErrors(output):
     return re.search(error_warning_regex, output) != None
 
 
-def verify_importScript_usage():
-    errors_found = False
-    for module in modules:
-        for file_name in module["sources"]:
-            if path.basename(file_name) == module_initializer_name:
-                log_error("Module initializer (%s) may not be listed among module's scripts; found in '%s'" % (module_initializer_name, module["name"]))
-                errors_found = True
-                continue
-            try:
-                with open(path.join(devtools_frontend_path, file_name), "r") as sourceFile:
-                    source = sourceFile.read()
-                    if re.search(importscript_regex, source):
-                        log_error("importScript() call only allowed in module initializers (%s); found in %s" % (module_initializer_name, file_name))
-                        errors_found = True
-            except:
-                log_error("Failed to access %s" % file_name)
-                raise
-    return errors_found
-
-
 def dump_all_checked_files():
     files = {}
     for module in modules:
         for source in module["sources"]:
             files[path.join(devtools_frontend_path, source)] = True
     return files.keys()
 
 
 def verify_jsdoc_extra(additional_files):
     return run_in_shell("%s -jar %s %s" % (java_exec, jsdoc_validator_jar, " ".join(dump_all_checked_files() + additional_files)))
@@ skipping 44 matching lines @@
     proc = subprocess.Popen("which java", stdout=subprocess.PIPE, shell=True)
     (javaPath, _) = proc.communicate()
 
     if proc.returncode != 0:
         print "Cannot find java ('which java' return code = %d, should be 0)" % proc.returncode
         sys.exit(1)
     print "Java executable: " + re.sub(r"\n$", "", javaPath)
 
 check_java_path()
 
-print "Verifying 'importScript' function usage..."
-errors_found |= verify_importScript_usage()
-
 modules_dir = tempfile.mkdtemp()
 common_closure_args = " --summary_detail_level 3 --jscomp_error visibility --compilation_level SIMPLE_OPTIMIZATIONS --warning_level VERBOSE --language_in ECMASCRIPT5 --accept_const_keyword --module_output_path_prefix %s/" % modules_dir
 
 spawned_compiler_command = "%s -jar %s %s \\\n" % (java_exec, closure_compiler_jar, common_closure_args)
 
 modules_by_name = {}
 standalone_modules_by_name = {}
 dependents_by_module_name = {}
 
 for module in modules:
@@ skipping 205 matching lines @@
 errors_found |= hasErrors(validateInjectedScriptOut)
 
 if errors_found:
     print "ERRORS DETECTED"
 
 os.remove(injectedScriptSourceTmpFile)
 os.remove(injectedScriptCanvasModuleSourceTmpFile)
 os.remove(compiler_args_file.name)
 os.remove(protocol_externs_file)
 shutil.rmtree(modules_dir, True)