Issue 472703002: Fix broken image links in GM and SKPs rebaselining

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 472703002: Fix broken image links in GM and SKPs rebaselining (Closed)

Created:
6 years, 4 months ago by stephana

Modified:
6 years, 4 months ago

Reviewers:
epoger

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

This is a bit of a hack, but will work. I have a cleaner fix ready (but still need to fix some broken tests). BUG=skia: NOTRY=true Committed: https://skia.googlesource.com/skia/+/e8d74d988a6c0138031d85dd8bd114c9f052f6f7

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -4 lines)			Patch
	M	gm/rebaseline_server/static/live-loader.js	View		1 chunk	+6 lines, -2 lines	0 comments	Download
	M	gm/rebaseline_server/static/loader.js	View		1 chunk	+6 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

epoger

LGTM. Thanks for the fix, Stephan. I have confirmed that tip-of-tree rebaseline_server fails (for both ...

6 years, 4 months ago (2014-08-14 02:11:54 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/stephana@google.com/472703002/1

6 years, 4 months ago (2014-08-14 02:12:36 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-08-14 02:13:07 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (1) as e8d74d988a6c0138031d85dd8bd114c9f052f6f7