Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: gm/rebaseline_server/static/loader.js

Issue 472703002: Fix broken image links in GM and SKPs rebaselining (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gm/rebaseline_server/static/live-loader.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/rebaseline_server/static/loader.js
diff --git a/gm/rebaseline_server/static/loader.js b/gm/rebaseline_server/static/loader.js
index e6030ad439b1cb671595d21b9d01abd600614df9..c3f69ba66f40d183cb350820283b1eab16bafe2d 100644
--- a/gm/rebaseline_server/static/loader.js
+++ b/gm/rebaseline_server/static/loader.js
@@ -1042,10 +1042,14 @@ Loader.controller(
*
* @param imagePair: ImagePair to generate image diff URL for
*/
+ // TODO (stephana): this is a temporary fix. A fix is in the works
+ // to get rid of this function and include the URL in the data
+ // sent from the backend.
+
$scope.getImageDiffRelativeUrl = function(imagePair) {
var before =
- imagePair[constants.KEY__IMAGEPAIRS__IMAGE_A_URL] + "-vs-" +
- imagePair[constants.KEY__IMAGEPAIRS__IMAGE_B_URL];
+ imagePair[constants.KEY__IMAGEPAIRS__IMAGE_A_URL] + "_png-vs-" +
+ imagePair[constants.KEY__IMAGEPAIRS__IMAGE_B_URL] + "_png";
return before.replace(/[^\w\-]/g, "_") + ".png";
};
« no previous file with comments | « gm/rebaseline_server/static/live-loader.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698