No need to release m_pBaseCS in CPDF_IndexedCS and CPDF_PatternCS

No need to release m_pBaseCS in CPDF_IndexedCS and CPDF_PatternCS

m_pBaseCS will be released in CPDF_DocPageData::Clear.

BUG=401372
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/489d483

[Bo Xu, 2014-08-15 18:45:43]

Tom, Ping:)

[Tom Sepez, 2014-08-15 18:54:44]

https://codereview.chromium.org/472653002/diff/1/core/src/fpdfapi/fpdf_page/f...
File core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp (right):

https://codereview.chromium.org/472653002/diff/1/core/src/fpdfapi/fpdf_page/f...
core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp:195: FX_POSITION pos_start =
m_ColorSpaceMap.GetStartPosition();
nit: I'd unroll the loop rather than trying to be clever.  Also a comment about
why we're doing this in this strange manner is desirable.

[Tom Sepez, 2014-08-15 18:58:48]

https://codereview.chromium.org/472653002/diff/1/core/src/fpdfapi/fpdf_page/f...
File core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp (right):

https://codereview.chromium.org/472653002/diff/1/core/src/fpdfapi/fpdf_page/f...
core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp:203: if ((bRelease || nCount < 2)
&& csData->m_Obj) {
What about csData's that dont have an m_Obj?  Looks like these don't get
released any more?

[Tom Sepez, 2014-08-15 18:59:29]

Finally, can we move this to the colorspacemap destructor so that the logic
doesn't proliferate here?

[Bo Xu, 2014-08-18 07:14:37]

On 2014/08/15 18:59:29, Tom Sepez wrote:
> Finally, can we move this to the colorspacemap destructor so that the logic
> doesn't proliferate here?

Hi Tom, I checked with the devs for the code. The m_pBaseCS was released in
~CPDF_IndexedCS() for multi-thread purpose. It has problems as shown here and
are not needed. Thanks for your insight.

[Tom Sepez, 2014-08-18 16:57:08]

On 2014/08/18 07:14:37, Bo Xu wrote:
> On 2014/08/15 18:59:29, Tom Sepez wrote:
> > Finally, can we move this to the colorspacemap destructor so that the logic
> > doesn't proliferate here?
> 
> Hi Tom, I checked with the devs for the code. The m_pBaseCS was released in
> ~CPDF_IndexedCS() for multi-thread purpose. It has problems as shown here and
> are not needed. Thanks for your insight.

Ok. LGTM.

[Bo Xu, 2014-08-18 16:59:07]

Committed patchset #2 manually as 489d483 (presubmit successful).