No need to release m_pBaseCS in CPDF_IndexedCS and CPDF_PatternCS

core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fpdfapi/fpdf_page.h"
 #include "../../../include/fpdfapi/fpdf_module.h"
 #include "../../../include/fdrm/fx_crypt.h"
 #include "../fpdf_font/font_int.h"
@@ skipping 174 matching lines @@
             m_ImageMap.GetNextAssoc(pos, objNum, imageData);
             nCount = imageData->m_nCount;
             if (bRelease || nCount < 2) {
                 delete imageData->m_Obj;
                 delete imageData;
                 m_ImageMap.RemoveKey(objNum);
             }
         }
     }
     {
-        pos = m_ColorSpaceMap.GetStartPosition();
-        while (pos) {
-            CPDF_Object* csKey;
-            CPDF_CountedObject<CPDF_ColorSpace*>* csData;
-            m_ColorSpaceMap.GetNextAssoc(pos, csKey, csData);
-            nCount = csData->m_nCount;
-            if (bRelease || nCount < 2) {
-                csData->m_Obj->ReleaseCS();
-                csData->m_Obj = NULL;
+        FX_POSITION pos_start = m_ColorSpaceMap.GetStartPosition();

[Tom Sepez, 2014/08/15 18:54:44]

nit: I'd unroll the loop rather than trying to be clever.  Also a comment about
why we're doing this in this strange manner is desirable.

+        for (int releaseLoop = 0; releaseLoop < 2; releaseLoop++){
+            pos = pos_start;
+            while (pos) {
+                CPDF_Object* csKey;
+                CPDF_CountedObject<CPDF_ColorSpace*>* csData;
+                m_ColorSpaceMap.GetNextAssoc(pos, csKey, csData);
+                nCount = csData->m_nCount;
+                if ((bRelease || nCount < 2) && csData->m_Obj) {

[Tom Sepez, 2014/08/15 18:58:48]

What about csData's that dont have an m_Obj?  Looks like these don't get
released any more?

+                    int CS_Family = csData->m_Obj->GetFamily();
+                    if ((releaseLoop == 0 && CS_Family == PDFCS_INDEXED) || (releaseLoop == 1 && CS_Family != PDFCS_INDEXED)) {
+                        csData->m_Obj->ReleaseCS();
+                        csData->m_Obj = NULL;
+                    }
+                }
             }
         }
     }
     {
         pos = m_IccProfileMap.GetStartPosition();
         while (pos) {
             CPDF_Stream* ipKey;
             CPDF_CountedObject<CPDF_IccProfile*>* ipData;
             m_IccProfileMap.GetNextAssoc(pos, ipKey, ipData);
             nCount = ipData->m_nCount;
@@ skipping 423 matching lines @@
     m_FontFileMap.SetAt(pFontStream, ftData);
     return pFontFile;
 }
 void CPDF_DocPageData::ReleaseFontFileStreamAcc(CPDF_Stream* pFontStream, FX_BOOL bForce)
 {
     if (!pFontStream) {
         return;
     }
     PDF_DocPageData_Release<CPDF_Stream*, CPDF_StreamAcc*>(m_FontFileMap, pFontStream, NULL, bForce);
 }