[Autofill] Modified to remove const qualifiers from FormField and AutofillScanner implementation.

[Autofill] Modified to remove const qualifiers from FormField and AutofillScanner implementation.

With current implemetation, most of the data-structures and function signature side Autofill FormField and AutofillScanner are kept const. Apparently any modification to FormFill becomes quite harder. At times, we endup using const_cast<>. Use of const_cast<> weakens the type system.

This patch removes const qualifiers from data-structures and function signatures from Autofill FormField and AutofillScanner implementation.

BUG=none

[Pritam Nikam, 2014-08-13 10:03:12]

Hi Ilya & Evan,

As suggested, I have removed const qualifiers from FormField and AutofillScanner
implementation in this patch. I didn't incorporate these changes in split credit
card field issue (https://codereview.chromium.org/381613005/) as it has changes
in other files as well like name, address, phone, email filed. 

Please have a look.

[Ilya Sherman, 2014-08-13 19:57:56]

Please merge this into the other CL.  This work is not needed except in the
context of that CL, so I'd prefer to include it there.

[Evan Stade, 2014-08-13 22:27:46]

I agree with Ilya that this should be merged into the other CL. That way, if we
have to revert or whatever, both get reverted together.

That said, I appreciate the ease of reviewing afforded by splitting this portion
of the change into a new CL, so I will review this here and after it looks good,
you can merge it into the other CL.

https://codereview.chromium.org/472433002/diff/1/components/autofill/core/bro...
File components/autofill/core/browser/email_field.cc (right):

https://codereview.chromium.org/472433002/diff/1/components/autofill/core/bro...
components/autofill/core/browser/email_field.cc:16: AutofillField* field;
this is the only change that's necessary for this file

https://codereview.chromium.org/472433002/diff/1/components/autofill/core/bro...
File components/autofill/core/browser/email_field.h (left):

https://codereview.chromium.org/472433002/diff/1/components/autofill/core/bro...
components/autofill/core/browser/email_field.h:25: const AutofillField* field_;
this is overboard. You can leave these consts.

[Pritam Nikam, 2014-08-16 04:26:11]

Thanks Evan and Ilya for review.
I've incorporated review comments in patch set #2. Please have a look.
As suggested, once review seems okay, I shall incorporate this CL to the
original (https://codereview.chromium.org/381613005/).

https://codereview.chromium.org/472433002/diff/1/components/autofill/core/bro...
File components/autofill/core/browser/email_field.cc (right):

https://codereview.chromium.org/472433002/diff/1/components/autofill/core/bro...
components/autofill/core/browser/email_field.cc:16: AutofillField* field;
On 2014/08/13 22:27:46, Evan Stade wrote:
> this is the only change that's necessary for this file

Done.

https://codereview.chromium.org/472433002/diff/1/components/autofill/core/bro...
File components/autofill/core/browser/email_field.h (left):

https://codereview.chromium.org/472433002/diff/1/components/autofill/core/bro...
components/autofill/core/browser/email_field.h:25: const AutofillField* field_;
On 2014/08/13 22:27:46, Evan Stade wrote:
> this is overboard. You can leave these consts.

Done.

[Evan Stade, 2014-08-18 18:29:33]

lg

[Pritam Nikam, 2014-08-19 11:52:48]

On 2014/08/18 18:29:33, Evan Stade wrote:
> lg

Thanks Evan!
I'll merge these changes in other CL
(https://codereview.chromium.org/381613005/).

[Pritam Nikam, 2014-09-17 02:01:21]

On 2014/08/19 11:52:48, Pritam Nikam wrote:
> On 2014/08/18 18:29:33, Evan Stade wrote:
> > lg
> 
> Thanks Evan!
> I'll merge these changes in other CL
> (https://codereview.chromium.org/381613005/).

Thanks Ilya & Evan!
Closing this review as (https://codereview.chromium.org/381613005/) closed.

Thanks.