Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: components/autofill/core/browser/credit_card_field.h

Issue 472433002: [Autofill] Modified to remove const qualifiers from FormField and AutofillScanner implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated review comments. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_CREDIT_CARD_FIELD_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_CREDIT_CARD_FIELD_H_
6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_CREDIT_CARD_FIELD_H_ 6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_CREDIT_CARD_FIELD_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 13 matching lines...) Expand all
24 24
25 protected: 25 protected:
26 // FormField: 26 // FormField:
27 virtual bool ClassifyField(ServerFieldTypeMap* map) const OVERRIDE; 27 virtual bool ClassifyField(ServerFieldTypeMap* map) const OVERRIDE;
28 28
29 private: 29 private:
30 friend class CreditCardFieldTest; 30 friend class CreditCardFieldTest;
31 31
32 CreditCardField(); 32 CreditCardField();
33 33
34 const AutofillField* cardholder_; // Optional. 34 AutofillField* cardholder_; // Optional.
35 35
36 // Occasionally pages have separate fields for the cardholder's first and 36 // Occasionally pages have separate fields for the cardholder's first and
37 // last names; for such pages cardholder_ holds the first name field and 37 // last names; for such pages cardholder_ holds the first name field and
38 // we store the last name field here. 38 // we store the last name field here.
39 // (We could store an embedded NameField object here, but we don't do so 39 // (We could store an embedded NameField object here, but we don't do so
40 // because the text patterns for matching a cardholder name are different 40 // because the text patterns for matching a cardholder name are different
41 // than for ordinary names, and because cardholder names never have titles, 41 // than for ordinary names, and because cardholder names never have titles,
42 // middle names or suffixes.) 42 // middle names or suffixes.)
43 const AutofillField* cardholder_last_; 43 AutofillField* cardholder_last_;
44 44
45 // TODO(jhawkins): Parse the select control. 45 // TODO(jhawkins): Parse the select control.
46 const AutofillField* type_; // Optional. 46 AutofillField* type_; // Optional.
47 const AutofillField* number_; // Required. 47 AutofillField* number_; // Required.
48 48
49 // The 3-digit card verification number; we don't currently fill this. 49 // The 3-digit card verification number; we don't currently fill this.
50 const AutofillField* verification_; 50 AutofillField* verification_;
51 51
52 // Either |expiration_date_| or both |expiration_month_| and 52 // Either |expiration_date_| or both |expiration_month_| and
53 // |expiration_year_| are required. 53 // |expiration_year_| are required.
54 const AutofillField* expiration_month_; 54 AutofillField* expiration_month_;
55 const AutofillField* expiration_year_; 55 AutofillField* expiration_year_;
56 const AutofillField* expiration_date_; 56 AutofillField* expiration_date_;
57 57
58 // True if the year is detected to be a 2-digit year; otherwise, we assume 58 // True if the year is detected to be a 2-digit year; otherwise, we assume
59 // a 4-digit year. 59 // a 4-digit year.
60 bool is_two_digit_year_; 60 bool is_two_digit_year_;
61 61
62 DISALLOW_COPY_AND_ASSIGN(CreditCardField); 62 DISALLOW_COPY_AND_ASSIGN(CreditCardField);
63 }; 63 };
64 64
65 } // namespace autofill 65 } // namespace autofill
66 66
67 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_CREDIT_CARD_FIELD_H_ 67 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_CREDIT_CARD_FIELD_H_
OLDNEW
« no previous file with comments | « components/autofill/core/browser/autofill_scanner.cc ('k') | components/autofill/core/browser/credit_card_field.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698