Issue 472423002: Fix ttcIndex value checking logic and intialize vars

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 472423002: Fix ttcIndex value checking logic and intialize vars (Closed)

Created:
6 years, 4 months ago by Dominik Röttsches

Modified:
6 years, 4 months ago

Reviewers:
Daniel Erat, jungshik at Google, eae

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@coreTextRemovalIncHalfWidth

Project:
blink

Visibility:
Public.

More Reviews

Description

Fix ttcIndex value checking logic and intialize vars Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180396

Patch Set 2 : -1 initialization #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	Source/platform/exported/linux/WebFontInfo.cpp	View	1	4 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

lgtm https://codereview.chromium.org/472423002/diff/1/Source/platform/exported/linux/WebFontInfo.cpp File Source/platform/exported/linux/WebFontInfo.cpp (right): https://codereview.chromium.org/472423002/diff/1/Source/platform/exported/linux/WebFontInfo.cpp#newcode93 Source/platform/exported/linux/WebFontInfo.cpp:93: int ttcIndex = 0; nit: initialize to -1, ...

6 years, 4 months ago (2014-08-15 22:40:55 UTC) #2

Dominik Röttsches

The CQ bit was checked by dominik.rottsches@intel.com

6 years, 4 months ago (2014-08-15 22:46:11 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/472423002/20001

6 years, 4 months ago (2014-08-15 22:47:08 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-08-15 23:55:09 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (20001) as 180396

Expand Messages | Collapse Messages

Issue 472423002: Fix ttcIndex value checking logic and intialize vars (Closed)

Description

Patch Set 1 #

Patch Set 2 : -1 initialization #

Messages