Fix ttcIndex value checking logic and intialize vars

Source/platform/exported/linux/WebFontInfo.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 52 matching lines @@
     }
     const WebFallbackFont& fallbackFont() const { return m_fallbackFont; }
     bool hasGlyphForCharacter(WebUChar32 c)
     {
         return m_supportedCharacters && FcCharSetHasChar(m_supportedCharacters, c);
     }
 
 private:
     static WebCString fontName(FcPattern* pattern)
     {
-        FcChar8* familyName;
+        FcChar8* familyName = nullptr;
         if (FcPatternGetString(pattern, FC_FAMILY, 0, &familyName) != FcResultMatch)
             return WebCString();
 
         // FCChar8 is unsigned char, so we cast to char for WebCString.
         const char* charFamily = reinterpret_cast<char*>(familyName);
         return WebCString(charFamily, strlen(charFamily));
     }
 
     static WebCString fontFilename(FcPattern* pattern)
     {
-        FcChar8* cFilename;
+        FcChar8* cFilename = nullptr;
         if (FcPatternGetString(pattern, FC_FILE, 0, &cFilename) != FcResultMatch)
             return WebCString();
         const char* fontFilename = reinterpret_cast<char*>(cFilename);
         return WebCString(fontFilename, strlen(fontFilename));
     }
 
     static int fontTtcIndex(FcPattern* pattern)
     {
-        int ttcIndex;
-        if (FcPatternGetInteger(pattern, FC_INDEX, 0, &ttcIndex) != FcResultMatch && ttcIndex < 0)
+        int ttcIndex = 0;

[Daniel Erat, 2014/08/15 22:40:54]

nit: initialize to -1, i.e. an invalid value per the test in the if condition

+        if (FcPatternGetInteger(pattern, FC_INDEX, 0, &ttcIndex) != FcResultMatch || ttcIndex < 0)
             return 0;
         return ttcIndex;
     }
 
     static bool fontIsBold(FcPattern* pattern)
     {
-        int weight;
+        int weight = 0;
         if (FcPatternGetInteger(pattern, FC_WEIGHT, 0, &weight) != FcResultMatch)
             return false;
         return weight >= FC_WEIGHT_BOLD;
     }
 
     static bool fontIsItalic(FcPattern* pattern)
     {
-        int slant;
+        int slant = 0;
         if (FcPatternGetInteger(pattern, FC_SLANT, 0, &slant) != FcResultMatch)
             return false;
         return slant != FC_SLANT_ROMAN;
     }
 
     WebFallbackFont m_fallbackFont;
     // m_supportedCharaters is owned by the parent
     // FcFontSet and should never be freed.
     FcCharSet* m_supportedCharacters;
 };
@@ skipping 138 matching lines @@
     typedef HashMap<AtomicString, OwnPtr<CachedFontSet> > LocaleToCachedFont;
     LocaleToCachedFont m_setsByLocale;
 };
 
 void WebFontInfo::fallbackFontForChar(WebUChar32 c, const char* locale, WebFallbackFont* fallbackFont)
 {
     *fallbackFont = FontSetCache::shared().fallbackFontForCharInLocale(c, locale);
 }
 
 } // namespace blink