Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 472333002: Remove deprecated chrome.pageActions api functions (Closed)

Created:
6 years, 4 months ago by Devlin
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated chrome.pageActions api functions chrome.pageActions.enableForTab and chrome.pageActions.disableForTab have been deprecated since the dawn of time. Let's finally remove them. BUG=166959 NOPRESUBMIT=true (histogram checks) R=isherman@chromium.org, kalman@chromium.org, thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290918

Patch Set 1 #

Patch Set 2 : +Renderer stuff #

Patch Set 3 : Latest master #

Patch Set 4 : histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -373 lines) Patch
M chrome/browser/extensions/api/extension_action/extension_action_api.h View 1 2 1 chunk +0 lines, -34 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_action_api.cc View 1 2 11 chunks +8 lines, -84 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/page_action_apitest.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
D chrome/common/extensions/api/page_actions.json View 1 chunk +0 lines, -52 lines 0 comments Download
M chrome/common/extensions/chrome_extensions_client.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions_api_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 1 3 chunks +0 lines, -7 lines 0 comments Download
D chrome/renderer/extensions/page_actions_custom_bindings.h View 1 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/renderer/extensions/page_actions_custom_bindings.cc View 1 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/renderer/resources/extensions/page_actions_custom_bindings.js View 1 1 chunk +0 lines, -22 lines 0 comments Download
M chrome/renderer/resources/renderer_resources.grd View 1 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/page_action/old_api/background.html View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/test/data/extensions/api_test/page_action/old_api/background.js View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/test/data/extensions/api_test/page_action/old_api/icon.png View Binary file 0 comments Download
D chrome/test/data/extensions/api_test/page_action/old_api/icon1.png View Binary file 0 comments Download
D chrome/test/data/extensions/api_test/page_action/old_api/manifest.json View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/test/data/extensions/api_test/page_action/old_api/page.html View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/test/data/extensions/api_test/page_action/old_api/page.js View 1 chunk +0 lines, -9 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 27 (0 generated)
Devlin
6 years, 4 months ago (2014-08-15 17:15:58 UTC) #1
not at google - send to devlin
You're missing some renderer files like page_actions_custom_bindings
6 years, 4 months ago (2014-08-15 17:18:39 UTC) #2
Devlin
On 2014/08/15 17:18:39, kalman wrote: > You're missing some renderer files like page_actions_custom_bindings ... What ...
6 years, 4 months ago (2014-08-15 17:34:07 UTC) #3
not at google - send to devlin
lgtm
6 years, 4 months ago (2014-08-15 17:43:01 UTC) #4
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 4 months ago (2014-08-18 21:31:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/472333002/40001
6 years, 4 months ago (2014-08-18 21:31:35 UTC) #6
Devlin
The CQ bit was unchecked by rdevlin.cronin@chromium.org
6 years, 4 months ago (2014-08-18 22:40:54 UTC) #7
Devlin
+isherman (histograms) +thestig (renderer_resources.grd, extensions_api_resources.grd)
6 years, 4 months ago (2014-08-18 22:42:14 UTC) #8
Lei Zhang
lgtm
6 years, 4 months ago (2014-08-18 22:48:19 UTC) #9
Ilya Sherman
Please run the script to update histograms.xml.
6 years, 4 months ago (2014-08-18 23:53:48 UTC) #10
Devlin
On 2014/08/18 23:53:48, Ilya Sherman wrote: > Please run the script to update histograms.xml. Whoops, ...
6 years, 4 months ago (2014-08-18 23:59:10 UTC) #11
Ilya Sherman
histograms lgtm
6 years, 4 months ago (2014-08-19 00:01:23 UTC) #12
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 4 months ago (2014-08-19 00:01:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/472333002/60001
6 years, 4 months ago (2014-08-19 00:03:08 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-19 01:37:42 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-19 01:41:12 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/5136)
6 years, 4 months ago (2014-08-19 01:41:13 UTC) #17
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 4 months ago (2014-08-19 21:54:22 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/472333002/60001
6 years, 4 months ago (2014-08-19 21:56:30 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-19 22:05:34 UTC) #20
Devlin
The CQ bit was unchecked by rdevlin.cronin@chromium.org
6 years, 4 months ago (2014-08-19 22:06:29 UTC) #21
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 4 months ago (2014-08-19 22:07:04 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/472333002/60001
6 years, 4 months ago (2014-08-19 22:09:07 UTC) #23
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-19 22:13:09 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-19 22:16:51 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/5343)
6 years, 4 months ago (2014-08-19 22:16:52 UTC) #26
Devlin
6 years, 4 months ago (2014-08-20 21:32:08 UTC) #27
Message was sent while issue was closed. 
Committed patchset #4 manually as 290918 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698