Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: chrome/browser/extensions/api/extension_action/page_action_apitest.cc

Issue 472333002: Remove deprecated chrome.pageActions api functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: histograms.xml Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/extension_action/extension_action_api.cc ('k') | chrome/chrome_renderer.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/extension_action/page_action_apitest.cc
diff --git a/chrome/browser/extensions/api/extension_action/page_action_apitest.cc b/chrome/browser/extensions/api/extension_action/page_action_apitest.cc
index db573dea2ab8f631011ac2985e11b9411cf05988..2cdd9f631db5cd7295b743da3215207b1364f1d3 100644
--- a/chrome/browser/extensions/api/extension_action/page_action_apitest.cc
+++ b/chrome/browser/extensions/api/extension_action/page_action_apitest.cc
@@ -159,34 +159,6 @@ IN_PROC_BROWSER_TEST_F(PageActionApiTest, RemovePopup) {
<< "Page action popup should have been removed.";
}
-// Tests old-style pageActions API that is deprecated but we don't want to
-// break.
-IN_PROC_BROWSER_TEST_F(PageActionApiTest, OldPageActions) {
- ASSERT_TRUE(RunExtensionTestAllowOldManifestVersion("page_action/old_api")) <<
- message_;
- const Extension* extension = GetSingleLoadedExtension();
- ASSERT_TRUE(extension) << message_;
-
- // Have the extension enable the page action.
- {
- ResultCatcher catcher;
- ui_test_utils::NavigateToURL(browser(),
- GURL(extension->GetResourceURL("page.html")));
- ASSERT_TRUE(catcher.GetNextResult());
- }
-
- // Simulate the page action being clicked.
- {
- ResultCatcher catcher;
- int tab_id = ExtensionTabUtil::GetTabId(
- browser()->tab_strip_model()->GetActiveWebContents());
- ExtensionAction* page_action = GetPageAction(*extension);
- ExtensionActionAPI::PageActionExecuted(
- browser()->profile(), *page_action, tab_id, std::string(), 1);
- EXPECT_TRUE(catcher.GetNextResult());
- }
-}
-
// Tests popups in page actions.
// Flaky on the trybots. See http://crbug.com/96725.
IN_PROC_BROWSER_TEST_F(PageActionApiTest, DISABLED_ShowPageActionPopup) {
« no previous file with comments | « chrome/browser/extensions/api/extension_action/extension_action_api.cc ('k') | chrome/chrome_renderer.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698