Issue 472303006: Revert "Move SkReadBuffer.h and SkReader32.h out of include."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 472303006: Revert "Move SkReadBuffer.h and SkReader32.h out of include." (Closed)

Created:
6 years, 4 months ago by hal.canary

Modified:
6 years, 4 months ago

Reviewers:
bungeman-skia

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert "Move SkReadBuffer.h and SkReader32.h out of include." This reverts commit 2a51d7c74cec217195f861677de8998b382b39e4. Breaking Blink NOTRY=true TBR=bungeman@google.com Committed: https://skia.googlesource.com/skia/+/f128f53a5bc36e2a991302cb40848df580ad515f

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -396 lines)			Patch
M	experimental/webtry/templates/template.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	gyp/core.gypi	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	gyp/public_headers.gypi	View	2 chunks	+2 lines, -0 lines	0 comments	Download
A	include/core/SkFlattenableBuffers.h	View	1 chunk	+10 lines, -0 lines	0 comments	Download
A +	include/core/SkReadBuffer.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	include/core/SkReader32.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	src/core/SkReadBuffer.h	View	1 chunk	+0 lines, -235 lines	0 comments	Download
D	src/core/SkReader32.h	View	1 chunk	+0 lines, -160 lines	0 comments	Download
M	tests/ImageFilterTest.cpp	View	2 chunks	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/472303006/1

6 years, 4 months ago (2014-08-18 20:48:07 UTC) #2

commit-bot: I haz the power

6 years, 4 months ago (2014-08-18 20:48:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (1) as f128f53a5bc36e2a991302cb40848df580ad515f