Don't use ServiceWorkerContainer.unregister in service_worker_unregister_and_register

Don't use ServiceWorkerContainer.unregister in service_worker_unregister_and_register

Another step toward removing the deprecated ServiceWorkerContainer.unregister.
service_worker_unregister_and_register is the biggest consumer of it in our
tests.

Now to unregister, the function first registers at that scope to get a
registration, then calls unregister on it. This only works with registrations
that cleanly install, which is the most common use case.

BUG=404064
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180426

[falken, 2014-08-15 12:17:08]

PTAL

https://codereview.chromium.org/472293002/diff/1/LayoutTests/http/tests/servi...
File LayoutTests/http/tests/serviceworker/serviceworkerobject-scripturl.html
(right):

https://codereview.chromium.org/472293002/diff/1/LayoutTests/http/tests/servi...
LayoutTests/http/tests/serviceworker/serviceworkerobject-scripturl.html:26:
url_test('with-fragment', 'resources/worker-no-op.js#ref');
Somehow this patch tickled the flakiness you probably were seeing in
https://codereview.chromium.org/466723002/

I think the problem is the different async tests use the same scope, so they run
concurrently mixing each other up.

[nhiroki, 2014-08-18 01:33:17]

Thank you for working on this! LGTM

https://codereview.chromium.org/472293002/diff/1/LayoutTests/http/tests/servi...
File LayoutTests/http/tests/serviceworker/install-phase-event-waituntil.html
(right):

https://codereview.chromium.org/472293002/diff/1/LayoutTests/http/tests/servi...
LayoutTests/http/tests/serviceworker/install-phase-event-waituntil.html:8: //
don't install succesfully.
nit: s/succesfully/successfully/

https://codereview.chromium.org/472293002/diff/1/LayoutTests/http/tests/servi...
LayoutTests/http/tests/serviceworker/install-phase-event-waituntil.html:16:
return navigator.serviceWorker.register(script, {scope:scope});
"scope:scope"
     ^^^ can you add a space after this colon?

https://codereview.chromium.org/472293002/diff/1/LayoutTests/http/tests/servi...
File LayoutTests/http/tests/serviceworker/serviceworkerobject-scripturl.html
(right):

https://codereview.chromium.org/472293002/diff/1/LayoutTests/http/tests/servi...
LayoutTests/http/tests/serviceworker/serviceworkerobject-scripturl.html:26:
url_test('with-fragment', 'resources/worker-no-op.js#ref');
On 2014/08/15 12:17:08, falken wrote:
> Somehow this patch tickled the flakiness you probably were seeing in
> https://codereview.chromium.org/466723002/
> 
> I think the problem is the different async tests use the same scope, so they
run
> concurrently mixing each other up.

Acknowledged.

[falken, 2014-08-18 05:01:06]

Thanks!

https://codereview.chromium.org/472293002/diff/1/LayoutTests/http/tests/servi...
File LayoutTests/http/tests/serviceworker/install-phase-event-waituntil.html
(right):

https://codereview.chromium.org/472293002/diff/1/LayoutTests/http/tests/servi...
LayoutTests/http/tests/serviceworker/install-phase-event-waituntil.html:8: //
don't install succesfully.
On 2014/08/18 01:33:17, nhiroki wrote:
> nit: s/succesfully/successfully/

Done.

https://codereview.chromium.org/472293002/diff/1/LayoutTests/http/tests/servi...
LayoutTests/http/tests/serviceworker/install-phase-event-waituntil.html:16:
return navigator.serviceWorker.register(script, {scope:scope});
On 2014/08/18 01:33:17, nhiroki wrote:
> "scope:scope"
>      ^^^ can you add a space after this colon?

Done.

https://codereview.chromium.org/472293002/diff/40001/LayoutTests/http/tests/s...
File LayoutTests/http/tests/serviceworker/resources/test-helpers.js (right):

https://codereview.chromium.org/472293002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/resources/test-helpers.js:17: 'unregister
and register should not fail'));
Added this error message to aid debugging.

[falken, 2014-08-18 05:01:18]

The CQ bit was checked by falken@chromium.org

[commit-bot: I haz the power, 2014-08-18 05:01:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/falken@chromium.org/472293002/40001

[commit-bot: I haz the power, 2014-08-18 06:00:51]

Committed patchset #3 (40001) as 180426