Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: LayoutTests/http/tests/serviceworker/resources/test-helpers.js

Issue 472293002: Don't use ServiceWorkerContainer.unregister in service_worker_unregister_and_register (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/serviceworker/resources/test-helpers.js
diff --git a/LayoutTests/http/tests/serviceworker/resources/test-helpers.js b/LayoutTests/http/tests/serviceworker/resources/test-helpers.js
index 0bae04421a4bb6364659d6bfde02151695ae6d71..a51c1a4a436f263d4e3c93bb2f1a8b80037b038f 100644
--- a/LayoutTests/http/tests/serviceworker/resources/test-helpers.js
+++ b/LayoutTests/http/tests/serviceworker/resources/test-helpers.js
@@ -1,23 +1,26 @@
// Adapter for testharness.js-style tests with Service Workers
+// Can only be used with a worker that installs successfully, since it
+// first registers to acquire a ServiceWorkerRegistration object to
+// unregister.
+// FIXME: Use getRegistration() when implemented.
function service_worker_unregister_and_register(test, url, scope) {
- var options = scope ? { scope: scope } : {};
- return navigator.serviceWorker.unregister(scope).then(
- test.step_func(function() {
- return navigator.serviceWorker.register(url, options);
- }),
- unreached_rejection(test, 'Unregister should not fail')
- ).then(test.step_func(function(worker) {
- return Promise.resolve(worker);
- }),
- unreached_rejection(test, 'Registration should not fail')
- );
+ var options = scope ? { scope: scope } : {};
+ return navigator.serviceWorker.register(url, options)
+ .then(function(registration) {
+ return registration.unregister();
+ })
+ .then(function() {
+ return navigator.serviceWorker.register(url, options);
+ })
+ .catch(unreached_rejection(test,
+ 'unregister and register should not fail'));
falken 2014/08/18 05:01:06 Added this error message to aid debugging.
}
function service_worker_unregister_and_done(test, scope) {
return navigator.serviceWorker.unregister(scope).then(
test.done.bind(test),
- unreached_rejection(test, 'Unregister should not fail'));
+ unreached_rejection(test, 'unregister should not fail'));
}
// Rejection-specific helper that provides more details

Powered by Google App Engine
This is Rietveld 408576698