Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 472263002: DevTools: make profiling lock global rather than per Target (Closed)

Created:
6 years, 4 months ago by yurys
Modified:
6 years, 4 months ago
Reviewers:
apavlov, sergeyv, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: make profiling lock global rather than per Target We should pause any actions that could affect performance if any of the targets is being profiled, not only current target. Compared to r180336 profiling lock is now initialized in Locks.js BUG=403684 R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180351

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -113 lines) Patch
M Source/devtools/devtools.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/audits/AuditLauncherView.js View 3 chunks +4 lines, -4 lines 0 comments Download
A Source/devtools/front_end/common/Lock.js View 1 chunk +48 lines, -0 lines 0 comments Download
M Source/devtools/front_end/common/Object.js View 1 chunk +0 lines, -45 lines 0 comments Download
M Source/devtools/front_end/inspector.html View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/profiler/CanvasProfileView.js View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/devtools/front_end/profiler/ProfilesPanel.js View 4 chunks +4 lines, -21 lines 0 comments Download
M Source/devtools/front_end/sdk/CSSStyleModel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/DOMModel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/DebuggerModel.js View 3 chunks +3 lines, -3 lines 0 comments Download
A Source/devtools/front_end/sdk/Locks.js View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/Target.js View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/TimelineManager.js View 3 chunks +3 lines, -6 lines 0 comments Download
M Source/devtools/front_end/sdk/TracingModel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/WorkerTargetManager.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 4 chunks +2 lines, -18 lines 0 comments Download
M Source/devtools/scripts/frontend_modules.json View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
I'm still not sure if it makes sense to initialize the lock lazily given that ...
6 years, 4 months ago (2014-08-15 09:41:00 UTC) #1
pfeldman
lgtm
6 years, 4 months ago (2014-08-15 10:50:55 UTC) #2
yurys
6 years, 4 months ago (2014-08-15 11:15:56 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as 180351 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698