Source/devtools/front_end/sdk/DOMModel.js - Issue 472263002: DevTools: make profiling lock global rather than per Target

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/sdk/DOMModel.js

Issue 472263002: DevTools: make profiling lock global rather than per Target (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/sdk/DOMModel.js

diff --git a/Source/devtools/front_end/sdk/DOMModel.js b/Source/devtools/front_end/sdk/DOMModel.js

index 0d3f0d3a33ffa9e3346fafacb5aa45c922ae3172..be592b3aeaf03629715ce15d6bfc6d1500a899b6 100644

--- a/Source/devtools/front_end/sdk/DOMModel.js

+++ b/Source/devtools/front_end/sdk/DOMModel.js

@@ -949,7 +949,7 @@ WebInspector.DOMModel = function(target) {

this._highlighter = this._defaultHighlighter;

if (WebInspector.experimentsSettings.disableAgentsWhenProfile.isEnabled())

- target.profilingLock.addEventListener(WebInspector.Lock.Events.StateChanged, this._profilingStateChanged, this);

+ WebInspector.profilingLock().addEventListener(WebInspector.Lock.Events.StateChanged, this._profilingStateChanged, this);

this._agent.enable();

}

@@ -970,7 +970,7 @@ WebInspector.DOMModel.Events = {

WebInspector.DOMModel.prototype = {

_profilingStateChanged: function()

{

- if (this.target().profilingLock.isAcquired())

+ if (WebInspector.profilingLock().isAcquired())

this._agent.disable();

else

this._agent.enable();