Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: chrome/browser/autocomplete/base_search_provider.h

Issue 471673002: Omnibox: Prevent Asynchronous Suggestions from Changing Default Match (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add clarifying comment Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/base_search_provider.h
diff --git a/chrome/browser/autocomplete/base_search_provider.h b/chrome/browser/autocomplete/base_search_provider.h
index d5557f5ddb3b42db32a56eb25d3678df48883f16..a6049c08623b887750fc9724cb707e184ebcb976 100644
--- a/chrome/browser/autocomplete/base_search_provider.h
+++ b/chrome/browser/autocomplete/base_search_provider.h
@@ -219,6 +219,11 @@ class BaseSearchProvider : public AutocompleteProvider,
virtual SearchSuggestionParser::Results* GetResultsToFill(
bool is_keyword) = 0;
+ // Optional. Called after a successful call to ParseSuggestResults(), this
+ // function provides the opportunity to do post-processing on the received
msw 2014/08/14 02:57:22 nit: s/provides the opportunity to do/allows/
Mark P 2014/08/15 00:05:56 Removed this function. Now obsolete.
+ // results.
+ virtual void HandleReceivedResults(bool is_keyword);
msw 2014/08/14 02:57:22 optional nit: OnParseSuggestResults, OnSuggestResu
Mark P 2014/08/15 00:05:56 Now obsolete.
+
// Returns whether the destination URL corresponding to the given |result|
// should contain command-line-specified query params.
virtual bool ShouldAppendExtraParams(

Powered by Google App Engine
This is Rietveld 408576698