Omnibox: Prevent Asynchronous Suggestions from Changing Default Match

chrome/browser/autocomplete/base_search_provider.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This class contains common functionality for search-based autocomplete
 // providers. Search provider and zero suggest provider both use it for common
 // functionality.
 
 #ifndef CHROME_BROWSER_AUTOCOMPLETE_BASE_SEARCH_PROVIDER_H_
 #define CHROME_BROWSER_AUTOCOMPLETE_BASE_SEARCH_PROVIDER_H_
@@ skipping 201 matching lines @@
   virtual const TemplateURL* GetTemplateURL(bool is_keyword) const = 0;
 
   // Returns the AutocompleteInput for keyword provider or default provider
   // based on the value of |is_keyword|.
   virtual const AutocompleteInput GetInput(bool is_keyword) const = 0;
 
   // Returns a pointer to a Results object, which will hold suggest results.
   virtual SearchSuggestionParser::Results* GetResultsToFill(
       bool is_keyword) = 0;
 
+  // Optional.  Called after a successful call to ParseSuggestResults(), this
+  // function provides the opportunity to do post-processing on the received

[msw, 2014/08/14 02:57:22]

nit: s/provides the opportunity to do/allows/

[Mark P, 2014/08/15 00:05:56]

Removed this function.  Now obsolete.

+  // results.
+  virtual void HandleReceivedResults(bool is_keyword);

[msw, 2014/08/14 02:57:22]

optional nit: OnParseSuggestResults, OnSuggestResultsParsed

[Mark P, 2014/08/15 00:05:56]

Now obsolete.

+
   // Returns whether the destination URL corresponding to the given |result|
   // should contain command-line-specified query params.
   virtual bool ShouldAppendExtraParams(
       const SearchSuggestionParser::SuggestResult& result) const = 0;
 
   // Stops the suggest query.
   // NOTE: This does not update |done_|.  Callers must do so.
   virtual void StopSuggest() = 0;
 
   // Clears the current results.
@@ skipping 51 matching lines @@
 
   // Each deletion handler in this vector corresponds to an outstanding request
   // that a server delete a personalized suggestion. Making this a ScopedVector
   // causes us to auto-cancel all such requests on shutdown.
   SuggestionDeletionHandlers deletion_handlers_;
 
   DISALLOW_COPY_AND_ASSIGN(BaseSearchProvider);
 };
 
 #endif  // CHROME_BROWSER_AUTOCOMPLETE_BASE_SEARCH_PROVIDER_H_