Omnibox: Prevent Asynchronous Suggestions from Changing Default Match

components/omnibox/search_suggestion_parser.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OMNIBOX_SEARCH_SUGGESTION_PARSER_H_
 #define COMPONENTS_OMNIBOX_SEARCH_SUGGESTION_PARSER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 36 matching lines @@
     bool from_keyword_provider() const { return from_keyword_provider_; }
 
     const base::string16& match_contents() const { return match_contents_; }
     const ACMatchClassifications& match_contents_class() const {
       return match_contents_class_;
     }
 
     AutocompleteMatchType::Type type() const { return type_; }
     int relevance() const { return relevance_; }
     void set_relevance(int relevance) { relevance_ = relevance; }
+    bool received_after_last_keystroke() const {
+      return received_after_last_keystroke_;
+    }
+    void set_received_after_last_keystroke(
+        bool received_after_last_keystroke) {
+      received_after_last_keystroke_ = received_after_last_keystroke;
+    }
 
     bool relevance_from_server() const { return relevance_from_server_; }
     void set_relevance_from_server(bool relevance_from_server) {
       relevance_from_server_ = relevance_from_server;
     }
 
     const std::string& deletion_url() const { return deletion_url_; }
 
     // Returns the default relevance value for this result (which may
     // be left over from a previous omnibox input) given the current
@@ skipping 16 matching lines @@
     int relevance_;
 
    private:
     // Whether this result's relevance score was fully or partly calculated
     // based on server information, and thus is assumed to be more accurate.
     // This is ultimately used in
     // SearchProvider::ConvertResultsToAutocompleteMatches(), see comments
     // there.
     bool relevance_from_server_;
 
+    // Whether this result was received asynchronously after the last
+    // keystroke, otherwise it must have come from prior cached results.

[msw, 2014/08/15 21:04:39]

nit: or from a synchronous provider, right?

[Mark P, 2014/08/15 22:09:22]

Nice clarification.  Added.

+    bool received_after_last_keystroke_;
+
     // Optional deletion URL provided with suggestions. Fetching this URL
     // should result in some reasonable deletion behaviour on the server,
     // e.g. deleting this term out of a user's server-side search history.
     std::string deletion_url_;
   };
 
   class SuggestResult : public Result {
    public:
     SuggestResult(const base::string16& suggestion,
                   AutocompleteMatchType::Type type,
@@ skipping 179 matching lines @@
 
  private:
   // Gets URLs of any images in Answers results.
   static void GetAnswersImageURLs(const base::DictionaryValue* answer_json,
                                   std::vector<GURL>* urls);
 
   DISALLOW_COPY_AND_ASSIGN(SearchSuggestionParser);
 };
 
 #endif  // COMPONENTS_OMNIBOX_SEARCH_SUGGESTION_PARSER_H_