Verify that gin_shell and hello_world.js exist.

Verify that gin_shell and hello_world.js exist.

This issue: https://code.google.com/p/chromium/issues/detail?id=398549,
was difficult to debug because gin/shell/gin_shell_unittest.cc didn't verify
that its input files existed before forging ahead.

The unit test now verifies that the gin_shell and hello_world.js paths
exist before launching the former and loading the latter.


BUG=398549
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289599

[hansmuller, 2014-08-13 16:56:36]

I've made the small change I promised to, just before the move
(https://codereview.chromium.org/424463004)

[abarth-chromium, 2014-08-13 18:00:16]

https://codereview.chromium.org/471623002/diff/40001/gin/shell/gin_shell_unit...
File gin/shell/gin_shell_unittest.cc (right):

https://codereview.chromium.org/471623002/diff/40001/gin/shell/gin_shell_unit...
gin/shell/gin_shell_unittest.cc:28: base::FilePath ginShellPath(GinShellPath());
gin_shell_path?

[hansmuller, 2014-08-13 19:22:14]

Fixed the variable names.

https://codereview.chromium.org/471623002/diff/40001/gin/shell/gin_shell_unit...
File gin/shell/gin_shell_unittest.cc (right):

https://codereview.chromium.org/471623002/diff/40001/gin/shell/gin_shell_unit...
gin/shell/gin_shell_unittest.cc:28: base::FilePath ginShellPath(GinShellPath());
On 2014/08/13 18:00:16, abarth wrote:
> gin_shell_path?

Yes, sorry about that. I've been writing a lot of JavaScript.

[abarth-chromium, 2014-08-13 19:27:32]

The CQ bit was checked by abarth@chromium.org

[abarth-chromium, 2014-08-13 19:27:32]

lgtm

[commit-bot: I haz the power, 2014-08-13 19:29:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hansmuller@chromium.org/471623002/60001

[commit-bot: I haz the power, 2014-08-14 09:52:50]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)

[commit-bot: I haz the power, 2014-08-14 15:45:20]

Committed patchset #4 (60001) as 289599