Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 424463004: Add gin/gin.gyp:gin_shell into chromium_builder_dbg_drmemory_win build target (Closed)

Created:
6 years, 4 months ago by zhaoqin
Modified:
6 years, 4 months ago
Reviewers:
hansmuller
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Add gin/gin.gyp:gin_shell into chromium_builder_dbg_drmemory_win build target for running gin_unittests GinShellTest.HelloWorld on Dr.Memory bots. NOTRY=true TBR=hansmuller@chromium.org BUG=398549 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286933

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
zhaoqin
6 years, 4 months ago (2014-07-31 18:47:13 UTC) #1
zhaoqin
The CQ bit was checked by zhaoqin@google.com
6 years, 4 months ago (2014-08-01 01:28:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhaoqin@google.com/424463004/1
6 years, 4 months ago (2014-08-01 01:30:05 UTC) #3
commit-bot: I haz the power
Change committed as 286933
6 years, 4 months ago (2014-08-01 01:33:00 UTC) #4
hansmuller
6 years, 4 months ago (2014-08-01 17:19:03 UTC) #5
Message was sent while issue was closed.
On 2014/07/31 18:47:13, zhaoqin wrote:

LGTM (the big move has me somewhat disconnected).

I think gin/shell/gin_shell_unittest.cc should check that the gin_shell and
hello_world.js paths exist before launching the former and loading the latter.
If this sort of failure were to crop up again, that would make the failure
symptoms relatively straightforward to interpret.

I can do that next week, when we're back in business.

Powered by Google App Engine
This is Rietveld 408576698