Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1714)

Unified Diff: chrome/browser/io_thread_unittest.cc

Issue 471613002: Change how QUIC negotiates pacing from congestion feedback to QUIC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Add_max_bandwidth_max_bandwidth_timestamp_73055131
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/io_thread_unittest.cc
diff --git a/chrome/browser/io_thread_unittest.cc b/chrome/browser/io_thread_unittest.cc
index 9a254146807fef75aad7c9e0e3bac1fea4db4c6d..e6a16c263ada1a0b81dbd217500dd7d07979afee 100644
--- a/chrome/browser/io_thread_unittest.cc
+++ b/chrome/browser/io_thread_unittest.cc
@@ -127,7 +127,6 @@ TEST_F(IOThreadTest, EnableQuicFromFieldTrialGroup) {
net::HttpNetworkSession::Params params;
InitializeNetworkSessionParams(&params);
EXPECT_TRUE(params.enable_quic);
- EXPECT_FALSE(params.enable_quic_pacing);
EXPECT_FALSE(params.enable_quic_time_based_loss_detection);
EXPECT_EQ(1350u, params.quic_max_packet_length);
EXPECT_EQ(default_params.quic_supported_versions,
@@ -153,7 +152,9 @@ TEST_F(IOThreadTest, EnablePacingFromCommandLine) {
ConfigureQuicGlobals();
net::HttpNetworkSession::Params params;
InitializeNetworkSessionParams(&params);
- EXPECT_TRUE(params.enable_quic_pacing);
+ net::QuicTagVector options;
+ options.push_back(net::kPACE);
+ EXPECT_EQ(options, params.quic_connection_options);
}
TEST_F(IOThreadTest, EnablePacingFromFieldTrialGroup) {
@@ -162,7 +163,9 @@ TEST_F(IOThreadTest, EnablePacingFromFieldTrialGroup) {
ConfigureQuicGlobals();
net::HttpNetworkSession::Params params;
InitializeNetworkSessionParams(&params);
- EXPECT_TRUE(params.enable_quic_pacing);
+ net::QuicTagVector options;
+ options.push_back(net::kPACE);
+ EXPECT_EQ(options, params.quic_connection_options);
}
TEST_F(IOThreadTest, EnablePacingFromFieldTrialParams) {
@@ -172,7 +175,9 @@ TEST_F(IOThreadTest, EnablePacingFromFieldTrialParams) {
ConfigureQuicGlobals();
net::HttpNetworkSession::Params params;
InitializeNetworkSessionParams(&params);
- EXPECT_TRUE(params.enable_quic_pacing);
+ net::QuicTagVector options;
+ options.push_back(net::kPACE);
+ EXPECT_EQ(options, params.quic_connection_options);
}
TEST_F(IOThreadTest, EnableTimeBasedLossDetectionFromCommandLine) {

Powered by Google App Engine
This is Rietveld 408576698