Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7066)

Unified Diff: chrome/browser/io_thread.cc

Issue 471613002: Change how QUIC negotiates pacing from congestion feedback to QUIC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Add_max_bandwidth_max_bandwidth_timestamp_73055131
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/io_thread.cc
diff --git a/chrome/browser/io_thread.cc b/chrome/browser/io_thread.cc
index a3773f6a4b2883054b44c7867cec4e85909fa7f4..6778373012c385d26668b88e3c272e43fef2fa5a 100644
--- a/chrome/browser/io_thread.cc
+++ b/chrome/browser/io_thread.cc
@@ -63,6 +63,7 @@
#include "net/proxy/proxy_config_service.h"
#include "net/proxy/proxy_script_fetcher_impl.h"
#include "net/proxy/proxy_service.h"
+#include "net/quic/crypto/crypto_protocol.h"
#include "net/quic/quic_protocol.h"
#include "net/socket/tcp_client_socket.h"
#include "net/spdy/spdy_session.h"
@@ -1044,8 +1045,6 @@ void IOThread::InitializeNetworkSessionParamsFromGlobals(
&params->enable_websocket_over_spdy);
globals.enable_quic.CopyToIfSet(&params->enable_quic);
- globals.enable_quic_pacing.CopyToIfSet(
- &params->enable_quic_pacing);
globals.enable_quic_time_based_loss_detection.CopyToIfSet(
&params->enable_quic_time_based_loss_detection);
globals.enable_quic_port_selection.CopyToIfSet(
@@ -1158,9 +1157,6 @@ void IOThread::ConfigureQuicGlobals(
bool enable_quic = ShouldEnableQuic(command_line, quic_trial_group);
globals->enable_quic.set(enable_quic);
if (enable_quic) {
- globals->enable_quic_pacing.set(
- ShouldEnableQuicPacing(command_line, quic_trial_group,
- quic_trial_params));
globals->enable_quic_time_based_loss_detection.set(
ShouldEnableQuicTimeBasedLossDetection(command_line, quic_trial_group,
quic_trial_params));
@@ -1168,6 +1164,10 @@ void IOThread::ConfigureQuicGlobals(
ShouldEnableQuicPortSelection(command_line));
globals->quic_connection_options =
GetQuicConnectionOptions(command_line, quic_trial_params);
+ if (ShouldEnableQuicPacing(command_line, quic_trial_group,
+ quic_trial_params)) {
+ globals->quic_connection_options.push_back(net::kPACE);
+ }
}
size_t max_packet_length = GetQuicMaxPacketLength(command_line,

Powered by Google App Engine
This is Rietveld 408576698