Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 471453003: Add an app_shell_unittests target (Closed)

Created:
6 years, 4 months ago by James Cook
Modified:
6 years, 4 months ago
Reviewers:
Yoyo Zhou, Daniel Erat
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add an app_shell_unittests target For now this uses extensions_unittests_main.cc as there are no differences in startup between extensions_unittests and app_shell_unittests. This allows ShellNaClBrowserDelegate to have a test. BUG=402612 TEST=app_shell_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290719

Patch Set 1 #

Patch Set 2 : (app-shell-tests) rebase #

Patch Set 3 : (app-shell-tests) fix GN build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -14 lines) Patch
M extensions/BUILD.gn View 1 2 2 chunks +9 lines, -8 lines 0 comments Download
M extensions/extensions.gyp View 1 3 chunks +7 lines, -6 lines 0 comments Download
M extensions/shell/app_shell.gyp View 1 chunk +18 lines, -0 lines 0 comments Download
A extensions/shell/browser/shell_nacl_browser_delegate_unittest.cc View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
James Cook
derat, PTAL
6 years, 4 months ago (2014-08-19 18:19:25 UTC) #1
Daniel Erat
lgtm
6 years, 4 months ago (2014-08-19 18:27:10 UTC) #2
James Cook
yoz, PTAL. I'm going to use this to test http://codereview.chromium.org/477113006 (and add more tests there, ...
6 years, 4 months ago (2014-08-19 18:28:27 UTC) #3
Yoyo Zhou
LGTM
6 years, 4 months ago (2014-08-19 18:49:31 UTC) #4
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 4 months ago (2014-08-19 21:14:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/471453003/20001
6 years, 4 months ago (2014-08-19 21:14:58 UTC) #6
James Cook
The CQ bit was unchecked by jamescook@chromium.org
6 years, 4 months ago (2014-08-19 21:29:44 UTC) #7
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 4 months ago (2014-08-19 21:37:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/471453003/40001
6 years, 4 months ago (2014-08-19 21:37:57 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 00:51:11 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (40001) as 290719

Powered by Google App Engine
This is Rietveld 408576698