DevTools: Split out the "workspace" and "bindings" modules from "sdk"

DevTools: Split out the "workspace" and "bindings" modules from "sdk"

This allows for a better code structure and code reuse by alternative
devtools frontends.

R=pfeldman@chromium.org, pfeldman, vsevik

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180253

[pfeldman, 2014-08-13 15:25:49]

lgtm

[apavlov, 2014-08-13 20:23:17]

The CQ bit was checked by apavlov@chromium.org

[commit-bot: I haz the power, 2014-08-13 20:24:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/apavlov@chromium.org/471433004/20001

[commit-bot: I haz the power, 2014-08-13 20:24:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-13 20:24:46]

Failed to apply patch for Source/devtools/devtools.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/devtools/devtools.gypi
  Hunk #5 FAILED at 131.
  1 out of 5 hunks FAILED -- saving rejects to file
Source/devtools/devtools.gypi.rej

Patch:       Source/devtools/devtools.gypi
Index: Source/devtools/devtools.gypi
diff --git a/Source/devtools/devtools.gypi b/Source/devtools/devtools.gypi
index
4a3699af408fb5c6ef7e957f563ae0f4de71dc01..74476cdaa5db137387a1b1b4d301aa378475580b
100644
--- a/Source/devtools/devtools.gypi
+++ b/Source/devtools/devtools.gypi
@@ -40,6 +40,8 @@
             '<@(devtools_host_js_files)',
             '<@(devtools_screencast_js_files)',
             '<@(devtools_sdk_js_files)',
+            '<@(devtools_workspace_js_files)',
+            '<@(devtools_bindings_js_files)',
             '<@(devtools_toolbox_js_files)',
             '<@(devtools_ui_js_files)',
         ],
@@ -63,6 +65,7 @@
         'devtools_common_js_files': [
             'front_end/common/Color.js',
             'front_end/common/Console.js',
+            'front_end/common/ContentProvider.js',
             'front_end/common/Geometry.js',
             'front_end/common/ModuleExtensionInterfaces.js',
             'front_end/common/modules.js',
@@ -70,7 +73,10 @@
             'front_end/common/Object.js',
             'front_end/common/ParsedURL.js',
             'front_end/common/Progress.js',
+            'front_end/common/ResourceType.js',
             'front_end/common/Settings.js',
+            'front_end/common/SourceCode.js',
+            'front_end/common/StaticContentProvider.js',
             'front_end/common/TextRange.js',
             'front_end/common/TextUtils.js',
             'front_end/common/Throttler.js',
@@ -117,11 +123,7 @@
         'devtools_sdk_js_files': [
             'front_end/sdk/ApplicationCacheModel.js',
             'front_end/sdk/BlackboxSupport.js',
-            'front_end/sdk/BreakpointManager.js',
-            'front_end/sdk/CompilerScriptMapping.js',
             'front_end/sdk/ConsoleModel.js',
-            'front_end/sdk/ContentProvider.js',
-            'front_end/sdk/ContentProviderBasedProjectDelegate.js',
             'front_end/sdk/ContentProviders.js',
             'front_end/sdk/CookieParser.js',
             'front_end/sdk/CPUProfileDataModel.js',
@@ -129,58 +131,64 @@
             'front_end/sdk/CSSMetadata.js',
             'front_end/sdk/CSSParser.js',
             'front_end/sdk/CSSStyleModel.js',
-            'front_end/sdk/CSSWorkspaceBinding.js',
             'front_end/sdk/Database.js',
             'front_end/sdk/DebuggerModel.js',
-            'front_end/sdk/DebuggerWorkspaceBinding.js',
-            'front_end/sdk/DefaultScriptMapping.js',
             'front_end/sdk/DOMModel.js',
             'front_end/sdk/DOMStorage.js',
-            'front_end/sdk/FileManager.js',
-            'front_end/sdk/FileSystemMapping.js',
             'front_end/sdk/FileSystemModel.js',
-            'front_end/sdk/FileSystemWorkspaceBinding.js',
-            'front_end/sdk/FileUtils.js',
             'front_end/sdk/HeapProfilerModel.js',
             'front_end/sdk/IndexedDBModel.js',
             'front_end/sdk/InspectorBackend.js',
-            'front_end/sdk/IsolatedFileSystem.js',
-            'front_end/sdk/IsolatedFileSystemManager.js',
             'front_end/sdk/LayerTreeModel.js',
-            'front_end/sdk/Linkifier.js',
-            'front_end/sdk/LiveEditSupport.js',
             'front_end/sdk/NetworkLog.js',
             'front_end/sdk/NetworkManager.js',
             'front_end/sdk/NetworkRequest.js',
-            'front_end/sdk/NetworkUISourceCodeProvider.js',
-            'front_end/sdk/NetworkWorkspaceBinding.js',
             'front_end/sdk/OverridesSupport.js',
             'front_end/sdk/PaintProfiler.js',
             'front_end/sdk/PowerProfiler.js',
-            'front_end/sdk/PresentationConsoleMessageHelper.js',
             'front_end/sdk/RemoteObject.js',
             'front_end/sdk/Resource.js',
-            'front_end/sdk/ResourceScriptMapping.js',
             'front_end/sdk/ResourceTreeModel.js',
-            'front_end/sdk/ResourceType.js',
-            'front_end/sdk/ResourceUtils.js',
             'front_end/sdk/RuntimeModel.js',
-            'front_end/sdk/SASSSourceMapping.js',
             'front_end/sdk/Script.js',
-            'front_end/sdk/ScriptSnippetModel.js',
-            'front_end/sdk/SearchConfig.js',
             'front_end/sdk/SnippetStorage.js',
             'front_end/sdk/SourceMap.js',
-            'front_end/sdk/SourceMapping.js',
-            'front_end/sdk/StylesSourceMapping.js',
             'front_end/sdk/Target.js',
-            'front_end/sdk/TempFile.js',
             'front_end/sdk/TimelineManager.js',
-            'front_end/sdk/UISourceCode.js',
             'front_end/sdk/WorkerManager.js',
             'front_end/sdk/WorkerTargetManager.js',
-            'front_end/sdk/Workspace.js',
-            'front_end/sdk/WorkspaceController.js',
+        ],
+        'devtools_workspace_js_files': [
+            'front_end/workspace/FileManager.js',
+            'front_end/workspace/FileSystemMapping.js',
+            'front_end/workspace/FileSystemWorkspaceBinding.js',
+            'front_end/workspace/IsolatedFileSystem.js',
+            'front_end/workspace/IsolatedFileSystemManager.js',
+            'front_end/workspace/SearchConfig.js',
+            'front_end/workspace/UISourceCode.js',
+            'front_end/workspace/Workspace.js',
+        ],
+        'devtools_bindings_js_files': [
+            'front_end/bindings/BreakpointManager.js',
+            'front_end/bindings/CompilerScriptMapping.js',
+            'front_end/bindings/ContentProviderBasedProjectDelegate.js',
+            'front_end/bindings/CSSWorkspaceBinding.js',
+            'front_end/bindings/DebuggerWorkspaceBinding.js',
+            'front_end/bindings/DefaultScriptMapping.js',
+            'front_end/bindings/FileUtils.js',
+            'front_end/bindings/Linkifier.js',
+            'front_end/bindings/LiveEditSupport.js',
+            'front_end/bindings/NetworkUISourceCodeProvider.js',
+            'front_end/bindings/NetworkWorkspaceBinding.js',
+            'front_end/bindings/PresentationConsoleMessageHelper.js',
+            'front_end/bindings/ResourceScriptMapping.js',
+            'front_end/bindings/ResourceUtils.js',
+            'front_end/bindings/SASSSourceMapping.js',
+            'front_end/bindings/ScriptSnippetModel.js',
+            'front_end/bindings/SourceMapping.js',
+            'front_end/bindings/StylesSourceMapping.js',
+            'front_end/bindings/TempFile.js',
+            'front_end/bindings/WorkspaceController.js',
         ],
         'devtools_toolbox_js_files': [
             'front_end/toolbox/InspectedPagePlaceholder.js',

[vsevik, 2014-08-14 07:42:52]

https://chromiumcodereview.appspot.com/471433004/diff/20001/Source/devtools/f...
File Source/devtools/front_end/workspace/UISourceCode.js (right):

https://chromiumcodereview.appspot.com/471433004/diff/20001/Source/devtools/f...
Source/devtools/front_end/workspace/UISourceCode.js:579: * @return
{!Array.<!WebInspector.PresentationMessage>}
We should move PresentationConsoleMessageHelper to bindings instead.

[apavlov, 2014-08-14 08:50:47]

The CQ bit was checked by apavlov@chromium.org

[commit-bot: I haz the power, 2014-08-14 08:52:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/apavlov@chromium.org/471433004/40001

[apavlov, 2014-08-14 09:57:05]

Committed patchset #3 manually as 180253 (presubmit successful).