Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1815)

Unified Diff: Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js

Issue 471433004: DevTools: Split out the "workspace" and "bindings" modules from "sdk" (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove marker interfaces and WI.SourceMapping Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
diff --git a/Source/devtools/front_end/sdk/DebuggerWorkspaceBinding.js b/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
similarity index 90%
rename from Source/devtools/front_end/sdk/DebuggerWorkspaceBinding.js
rename to Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
index 48db995466faf388db90845418c7aa8470d726e7..2e81df3709dc0a0cf86673505cb523ad77221e9a 100644
--- a/Source/devtools/front_end/sdk/DebuggerWorkspaceBinding.js
+++ b/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
@@ -53,7 +53,7 @@ WebInspector.DebuggerWorkspaceBinding.prototype = {
/**
* @param {!WebInspector.Script} script
- * @param {!WebInspector.SourceMapping} sourceMapping
+ * @param {!WebInspector.DebuggerSourceMapping} sourceMapping
*/
pushSourceMapping: function(script, sourceMapping)
{
@@ -63,7 +63,7 @@ WebInspector.DebuggerWorkspaceBinding.prototype = {
/**
* @param {!WebInspector.Script} script
- * @return {!WebInspector.SourceMapping}
+ * @return {!WebInspector.DebuggerSourceMapping}
*/
popSourceMapping: function(script)
{
@@ -75,7 +75,7 @@ WebInspector.DebuggerWorkspaceBinding.prototype = {
/**
* @param {!WebInspector.Target} target
* @param {!WebInspector.UISourceCode} uiSourceCode
- * @param {?WebInspector.SourceMapping} sourceMapping
+ * @param {?WebInspector.DebuggerSourceMapping} sourceMapping
*/
setSourceMapping: function(target, uiSourceCode, sourceMapping)
{
@@ -150,7 +150,7 @@ WebInspector.DebuggerWorkspaceBinding.prototype = {
* @param {!WebInspector.UISourceCode} uiSourceCode
* @param {number} lineNumber
* @param {number} columnNumber
- * @return {!Array.<!WebInspector.RawLocation>}
+ * @return {!Array.<!WebInspector.DebuggerModel.Location>}
*/
uiLocationToRawLocations: function(uiSourceCode, lineNumber, columnNumber)
{
@@ -304,7 +304,7 @@ WebInspector.DebuggerWorkspaceBinding.TargetData = function(target, debuggerWork
/** @type {!WebInspector.LiveEditSupport} */
this._liveEditSupport = new WebInspector.LiveEditSupport(target, workspace, debuggerWorkspaceBinding);
- /** @type {!Map.<!WebInspector.UISourceCode, !WebInspector.SourceMapping>} */
+ /** @type {!Map.<!WebInspector.UISourceCode, !WebInspector.DebuggerSourceMapping>} */
this._uiSourceCodeToSourceMapping = new Map();
debuggerModel.addEventListener(WebInspector.DebuggerModel.Events.ParsedScriptSource, this._parsedScriptSource, this);
@@ -333,7 +333,7 @@ WebInspector.DebuggerWorkspaceBinding.TargetData.prototype = {
/**
* @param {!WebInspector.UISourceCode} uiSourceCode
- * @param {?WebInspector.SourceMapping} sourceMapping
+ * @param {?WebInspector.DebuggerSourceMapping} sourceMapping
*/
_setSourceMapping: function(uiSourceCode, sourceMapping)
{
@@ -352,7 +352,7 @@ WebInspector.DebuggerWorkspaceBinding.TargetData.prototype = {
* @param {!WebInspector.UISourceCode} uiSourceCode
* @param {number} lineNumber
* @param {number} columnNumber
- * @return {?WebInspector.RawLocation}
+ * @return {?WebInspector.DebuggerModel.Location}
*/
_uiLocationToRawLocation: function(uiSourceCode, lineNumber, columnNumber)
{
@@ -396,7 +396,7 @@ WebInspector.DebuggerWorkspaceBinding.ScriptInfo = function(script)
{
this._script = script;
- /** @type {!Array.<!WebInspector.SourceMapping>} */
+ /** @type {!Array.<!WebInspector.DebuggerSourceMapping>} */
this._sourceMappings = [];
/** @type {!Set.<!WebInspector.LiveLocation>} */
@@ -405,7 +405,7 @@ WebInspector.DebuggerWorkspaceBinding.ScriptInfo = function(script)
WebInspector.DebuggerWorkspaceBinding.ScriptInfo.prototype = {
/**
- * @param {!WebInspector.SourceMapping} sourceMapping
+ * @param {!WebInspector.DebuggerSourceMapping} sourceMapping
*/
_pushSourceMapping: function(sourceMapping)
{
@@ -414,7 +414,7 @@ WebInspector.DebuggerWorkspaceBinding.ScriptInfo.prototype = {
},
/**
- * @return {!WebInspector.SourceMapping}
+ * @return {!WebInspector.DebuggerSourceMapping}
*/
_popSourceMapping: function()
{
@@ -472,8 +472,9 @@ WebInspector.DebuggerWorkspaceBinding.ScriptInfo.prototype = {
*/
WebInspector.DebuggerWorkspaceBinding.Location = function(script, rawLocation, binding, updateDelegate)
{
- WebInspector.LiveLocation.call(this, rawLocation, updateDelegate);
+ WebInspector.LiveLocation.call(this, updateDelegate);
this._script = script;
+ this._rawLocation = rawLocation;
this._binding = binding;
}
@@ -483,7 +484,7 @@ WebInspector.DebuggerWorkspaceBinding.Location.prototype = {
*/
uiLocation: function()
{
- var debuggerModelLocation = /** @type {!WebInspector.DebuggerModel.Location} */ (this.rawLocation());
+ var debuggerModelLocation = this._rawLocation;
return this._binding.rawLocationToUILocation(debuggerModelLocation);
},
@@ -497,6 +498,41 @@ WebInspector.DebuggerWorkspaceBinding.Location.prototype = {
}
/**
+ * @interface
+ */
+WebInspector.DebuggerSourceMapping = function()
+{
+}
+
+WebInspector.DebuggerSourceMapping.prototype = {
+ /**
+ * @param {!WebInspector.DebuggerModel.Location} rawLocation
+ * @return {?WebInspector.UILocation}
+ */
+ rawLocationToUILocation: function(rawLocation) { },
+
+ /**
+ * @param {!WebInspector.UISourceCode} uiSourceCode
+ * @param {number} lineNumber
+ * @param {number} columnNumber
+ * @return {?WebInspector.DebuggerModel.Location}
+ */
+ uiLocationToRawLocation: function(uiSourceCode, lineNumber, columnNumber) { },
+
+ /**
+ * @return {boolean}
+ */
+ isIdentity: function() { },
+
+ /**
+ * @param {!WebInspector.UISourceCode} uiSourceCode
+ * @param {number} lineNumber
+ * @return {boolean}
+ */
+ uiLineHasMapping: function(uiSourceCode, lineNumber) { }
+}
+
+/**
* @type {!WebInspector.DebuggerWorkspaceBinding}
*/
WebInspector.debuggerWorkspaceBinding;

Powered by Google App Engine
This is Rietveld 408576698