Landing Recent QUIC Changes.

Landing Recent QUIC Changes.

Change how QUIC negotiates pacing from congestion feedback to QUIC
connection option.

Merge internal change: 73061068
https://codereview.chromium.org/471613002/


Add max_bandwidth and max_bandwidth_timestamp to QUIC source address
token.

Merge internal change: 73055131
https://codereview.chromium.org/463093003/


Don't print (SCUP) in log message, the DebugString that follows contains
this already.

Merge internal change: 73054570
https://codereview.chromium.org/464893003/


Do not support Quic timestamp feedback type in the framer.

Merge internal change: 72905602
https://codereview.chromium.org/467893002/


Change QUIC's delayed ack timer from 100ms to 25ms.

Rationale: This delay kicks in when the receiver is waiting for a second
data packet before sending an ack, and 100ms seems inordinately long for
this wait. The timer fires per-packet in low-bandwidth network paths
(BW < ~384 kbps), where more frequent acks helps with (i) ack clocking,
and (ii) better bw estimation for BBR.

Merge internal change: 72788368
https://codereview.chromium.org/461183002/


QUIC - clean up changes to keep in sync with internal source tree.
https://codereview.chromium.org/454263002/

R=rch@chromium.org
TBR=thestig@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290018

[ramant (doing other things), 2014-08-14 23:45:22]

On 2014/08/14 23:23:39, ramant wrote:

Hi Lei Zhang,
  Would appreciate if you could take a look at chrome/browser changes. The
changes in chrome/browser were same as the changes rch's LGTM'ed in
https://codereview.chromium.org/471613002/

  Will land CL: https://codereview.chromium.org/470493004/ after landing this
CL.

thanks
raman

[Ryan Hamilton, 2014-08-15 14:31:39]

lgtm

[ramant (doing other things), 2014-08-15 16:16:42]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-08-15 16:17:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rtenneti@chromium.org/471293002/20001

[wtc, 2014-08-15 18:54:57]

Patch set 1 LGTM.

https://codereview.chromium.org/471293002/diff/20001/net/quic/quic_protocol.h
File net/quic/quic_protocol.h (right):

https://codereview.chromium.org/471293002/diff/20001/net/quic/quic_protocol.h...
net/quic/quic_protocol.h:108: const int kMaxDelayedAckTime = 25;

Nit: it would be a good idea to add "Ms" to the constant name. That seems to be
the convention in this file. See kMaxInitialRoundTripTimeUs on line 76 and
kDefaultInitialTimeoutSecs etc. on line 112. You can make this change in the
internal tree first.

[commit-bot: I haz the power, 2014-08-15 21:39:06]

Committed patchset #1 (20001) as 290018

[ramant (doing other things), 2014-08-19 17:48:41]

https://codereview.chromium.org/471293002/diff/20001/net/quic/quic_protocol.h
File net/quic/quic_protocol.h (right):

https://codereview.chromium.org/471293002/diff/20001/net/quic/quic_protocol.h...
net/quic/quic_protocol.h:108: const int kMaxDelayedAckTime = 25;
On 2014/08/15 18:54:57, wtc wrote:
> 
> Nit: it would be a good idea to add "Ms" to the constant name. That seems to
be
> the convention in this file. See kMaxInitialRoundTripTimeUs on line 76 and
> kDefaultInitialTimeoutSecs etc. on line 112. You can make this change in the
> internal tree first.

Thanks for making the above change in the internal source tree. Will merge that
in future CL.

Done.