Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1097)

Unified Diff: net/quic/quic_connection.cc

Issue 471293002: Landing Recent QUIC Changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_connection.cc
diff --git a/net/quic/quic_connection.cc b/net/quic/quic_connection.cc
index f40b34dfe590af5b07e40d2d6115ad8c8e69a2ba..a4305f62c71bfd1de98ed44f2e7e8cd6c1f5c288 100644
--- a/net/quic/quic_connection.cc
+++ b/net/quic/quic_connection.cc
@@ -237,10 +237,13 @@ QuicConnection::QuicConnection(QuicConnectionId connection_id,
peer_port_changed_(false),
self_ip_changed_(false),
self_port_changed_(false) {
+#if 0
+ // TODO(rtenneti): Should we enable this code in chromium?
if (!is_server_) {
// Pacing will be enabled if the client negotiates it.
sent_packet_manager_.MaybeEnablePacing();
}
+#endif
DVLOG(1) << ENDPOINT << "Created connection with connection_id: "
<< connection_id;
timeout_alarm_->Set(clock_->ApproximateNow().Add(idle_network_timeout_));
@@ -1698,6 +1701,9 @@ void QuicConnection::MaybeProcessUndecryptablePackets() {
// never be able to be decrypted.
if (encryption_level_ == ENCRYPTION_FORWARD_SECURE) {
if (debug_visitor_.get() != NULL) {
+ // TODO(rtenneti): perhaps more efficient to pass the number of
+ // undecryptable packets as the argument to OnUndecryptablePacket so that
+ // we just need to call OnUndecryptablePacket once?
for (size_t i = 0; i < undecryptable_packets_.size(); ++i) {
debug_visitor_->OnUndecryptablePacket();
}

Powered by Google App Engine
This is Rietveld 408576698